MergeCommand.cs: ensure a timestamp and use new cyclonedx-dotnet-library features… - #334
MergeCommand.cs: ensure a timestamp and use new cyclonedx-dotnet-library features…#334jimklimov wants to merge 2 commits into
Conversation
…MetadataComponent() and CleanupEmptyLists() as a finishing touch, to avoid inducing a spec violation with a duplicate bom-ref Signed-off-by: Jim Klimov <jimklimov@gmail.com>
bdf6013 to
cea2b51
Compare
Signed-off-by: Jim Klimov <jimklimov@gmail.com>
ProlucidPB
left a comment
There was a problem hiding this comment.
Would love to see this merged in soon!
|
@mtsfoni : Would you have time to review this PR? Please. |
|
FYI: This PR is part of a series I've opened 3 years ago, and stalled in review for whatever reasons including the under-the-hood use of reflection to implement inspection of arbitrary BOM entities to merge them, including the ones still open at this time:
I (and my dayjob's budget) have recently employed Claude AI to pick up where I left long ago, and rewrite those changes in idiomatic C#, rebased over current upstream achievements. After some internal dev-testing shows that this rewrite is successful, I hope these old PRs will be supplanted by a new series with new technological base and same or better feature set as what I was stuck with using (slowly bit-rotting over the years). Hopefully the new set of PRs would be less questionable for an upstream merge :) I'll add this note to all impacted PRs listed above. |
…to CleanupMetadataComponent() and CleanupEmptyLists() as a finishing touch, to avoid inducing a spec violation with a duplicate bom-ref
The new cleanup features depend on library PR CycloneDX/cyclonedx-dotnet-library#245