Skip to content

CC2 Phase 0: scaffolding, colossalchests2 rename, CC1 teardown #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubensworks merged 6 commits into from
Oct 3, 2026
Merged

CC2 Phase 0: scaffolding, colossalchests2 rename, CC1 teardown #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
92e9610
Phase 0: scaffold Colossal Chests 2
claude Sep 28, 2026
6a13c9a
Address Phase 0 review comments
claude Sep 28, 2026
e52b172
Use the mod description in the lang file
claude Oct 3, 2026
e65d68d
Make the data tables extensible per entry
claude Oct 3, 2026
c19bbc8
Make config javadoc standalone
claude Oct 3, 2026
b2eaf98
Move chest-wide values to GeneralConfig
claude Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .imgbotconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
"ignoredFiles": [
"loader-common/src/main/resources/assets/colossalchests/textures/gui/colossal_chest.png"
"loader-common/src/main/resources/assets/colossalchests2/textures/gui/colossal_chest.png"
]
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
[![CurseForge](http://cf.way2muchnoise.eu/full_237875_downloads.svg)](https://www.curseforge.com/minecraft/mc-mods/colossal-chests)
[![Discord](https://img.shields.io/discord/386052815128100865.svg?colorB=7289DA&logo=data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAHYAAABWAgMAAABnZYq0AAAACVBMVEUAAB38%2FPz%2F%2F%2F%2Bm8P%2F9AAAAAXRSTlMAQObYZgAAAAFiS0dEAIgFHUgAAAAJcEhZcwAACxMAAAsTAQCanBgAAAAHdElNRQfhBxwQJhxy2iqrAAABoElEQVRIx7WWzdGEIAyGgcMeKMESrMJ6rILZCiiBg4eYKr%2Fd1ZAfgXFm98sJfAyGNwno3G9sLucgYGpQ4OGVRxQTREMDZjF7ILSWjoiHo1n%2BE03Aw8p7CNY5IhkYd%2F%2F6MtO3f8BNhR1QWnarCH4tr6myl0cWgUVNcfMcXACP1hKrGMt8wcAyxide7Ymcgqale7hN6846uJCkQxw6GG7h2MH4Czz3cLqD1zHu0VOXMfZjHLoYvsdd0Q7ZvsOkafJ1P4QXxrWFd14wMc60h8JKCbyQvImzlFjyGoZTKzohwWR2UzSONHhYXBQOaKKsySsahwGGDnb%2FiYPJw22sCqzirSULYy1qtHhXGbtgrM0oagBV4XiTJok3GoLoDNH8ooTmBm7ZMsbpFzi2bgPGoXWXME6XT%2BRJ4GLddxJ4PpQy7tmfoU2HPN6cKg%2BledKHBKlF8oNSt5w5g5o8eXhu1IOlpl5kGerDxIVT%2BztzKepulD8utXqpChamkzzuo7xYGk%2FkpSYuviLXun5bzdRf0Krejzqyz7Z3p0I1v2d6HmA07dofmS48njAiuMgAAAAASUVORK5CYII%3D)](https://discord.gg/9yDxubB)

For when regular chests are too small
Chests that are quite colossal, and can be upgraded.

All stable releases (including deobfuscated builds) can be found on [CurseForge](https://www.curseforge.com/minecraft/mc-mods/colossal-chests/files).

Expand Down
9 changes: 9 additions & 0 deletions buildSrc/src/main/groovy/multiloader-loader-common.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,12 @@ artifacts {
commonResources sourceSets.main.resources.sourceDirectories.singleFile
}


// Unit tests in common run against vanilla Minecraft classes.
neoForge {

@rubensworks rubensworks Sep 28, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure the changes in this file will work, since this is common to all loaders?...

@rubensworks rubensworks Sep 28, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Despite the name, multiloader-loader-common.gradle is only applied by loader-common/build.gradle. The loader modules apply multiloader-loader.gradle and the per-loader scripts instead, and both of those only pull in multiloader-common.gradle. So addModdingDependenciesTo(sourceSets.test) and the JUnit dependency only affect the common module's test source set, which puts vanilla classes on its test classpath.

I checked this with ./gradlew build (common tests ran: 4 in Phase 0, 81 once Phase 1 is added) and ./gradlew runGameTestServer. Both pass on Fabric, Forge and NeoForge, and the loader test tasks are unaffected (NO-SOURCE).

Generated by Claude Code

addModdingDependenciesTo(sourceSets.test)
}

dependencies {
testImplementation "junit:junit:4.13.2"
}
4 changes: 2 additions & 2 deletions crowdin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ base_path: .
preserve_hierarchy: true

files:
- source: loader-common/src/main/resources/assets/colossalchests/lang/en_us.json
translation: loader-common/src/main/resources/assets/colossalchests/lang/%locale_with_underscore%.json
- source: loader-common/src/main/resources/assets/colossalchests2/lang/en_us.json
translation: loader-common/src/main/resources/assets/colossalchests2/lang/%locale_with_underscore%.json
excluded_target_languages:
- en
skip_untranslated_strings: true
Expand Down
10 changes: 5 additions & 5 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
# Project
mod_version=1.9.1
group=org.cyclops.colossalchests
mod_version=2.0.0
group=org.cyclops.colossalchests2
java_version=21

# Common
minecraft_version=1.21.1
mod_name=ColossalChests
mod_name=ColossalChests2
mod_author=rubensworks (aka kroeser)
mod_id=colossalchests
mod_id=colossalchests2
license=MIT
github_url=https://github.com/CyclopsMC/ColossalChests
issue_tracker_url=https://github.com/CyclopsMC/ColossalChests/issues
display_url=https://www.curseforge.com/minecraft/mc-mods/colossal-chests
Comment thread
rubensworks marked this conversation as resolved.
description=For when regular chests are too small.
description=Chests that are quite colossal, and can be upgraded.
fingerprint=bd0353b3e8a2810d60dd584e256e364bc3bedd44
neo_form_version=1.21-20240613.152323
parchment_version=2024.06.23
Expand Down
53 changes: 0 additions & 53 deletions loader-common/src/main/java/org/cyclops/colossalchests/GeneralConfig.java
View file
Open in desktop

This file was deleted.

39 changes: 0 additions & 39 deletions loader-common/src/main/java/org/cyclops/colossalchests/RegistryEntries.java
View file
Open in desktop

This file was deleted.

51 changes: 0 additions & 51 deletions ...on/src/main/java/org/cyclops/colossalchests/advancement/criterion/ChestFormedTrigger.java
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions .../main/java/org/cyclops/colossalchests/advancement/criterion/ChestFormedTriggerConfig.java
View file
Open in desktop

This file was deleted.

166 changes: 0 additions & 166 deletions loader-common/src/main/java/org/cyclops/colossalchests/block/ChestMaterial.java
View file
Open in desktop

This file was deleted.

Loading
Loading