Colossal Chests 2, Phase 7: Redstone wall - #225
Open
rubensworks wants to merge 3 commits into
Open
rubensworks wants to merge 3 commits into
rubensworks wants to merge 3 commits into
Conversation
A functional wall whose comparator output follows the whole chest, like the core, or the slots holding one item type. The item is set through a ghost slot in its settings, opened by sneak-right-click with an empty hand, which also shows the current signal. The core refreshes Redstone walls when its contents change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RSz5r6eowhjNuANBjZE2v6
Member
Author
|
CI note: one of the two Coveralls is red as before: coverage dropped 0.2% to 74.7%, mostly from the new screen code that tests can't reach. Generated by Claude Code |
Besides the comparator output, the wall now emits the same signal as weak power to every side, like a trapped chest, so dust and lamps work without a comparator. The emitted value is kept on the block entity and refreshed when the chest's contents or the target change, and every 10 ticks to catch the chest forming or breaking; neighbours are only updated when it changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RSz5r6eowhjNuANBjZE2v6
Comparators read the same value the wall emits, so like the neighbour update, the comparator update is skipped while the value stays the same. This keeps hopper traffic and the periodic check free of updates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RSz5r6eowhjNuANBjZE2v6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Redstone wall, as its own PR (one feature per PR). The Magnet wall follows separately.
Summary
Design deviations
Validation
TestStorageSignals(3 new): absent type gives 0, only the type's slots count, a single item gives 1testRedstoneWallSignalTotals: 293 unit tests; game tests Fabric 74, Forge 72, NeoForge 72, all passing.
In-game (clientdevbridge): script and screenshots in
clientdevbridge-screenshots/phase7c-redstone. On NeoForge, an iron 3x3 with a Redstone wall, a comparator, redstone dust and a lamp, and a second Redstone wall with a lamp directly against it:Not checked in-game on Fabric or Forge, and not re-run in-game after the last commit, which only skips comparator updates while the value is unchanged.
Known issues
🤖 Generated with Claude Code
https://claude.ai/code/session_01RSz5r6eowhjNuANBjZE2v6