Repository navigation
Fix Fabric crash when rendering fluids without tint source - #250
Merged
Merged
Conversation
FluidModel#tintSource is null for untinted fluids such as lava, which caused an NPE in RenderHelpersFabric#getFluidVertexBufferColor, e.g. when rendering lava in a Flopper. Related to CyclopsMC/Flopper#47 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TVes4otYKR6fj4dbo5sZhD
|
coverage: 31.409% (-0.006%) from 31.415% — fix-fluid-tint-npe into master-26-lts |
rubensworks
commented
Oct 1, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FluidModel#tintSource()is null for untinted fluids such as lava.RenderHelpersFabric#getFluidVertexBufferColordereferenced it without a check, which crashes the client, for example when a Flopper containing lava is rendered (CyclopsMC/Flopper#47):Untinted fluids now fall back to white (no tint).
Targets
master-26-ltsso the fix upmerges intomaster-26.2andmaster-26, which have the same code.Note: not compiled locally, as dependency resolution was rate limited (HTTP 429 from Maven Central) in the build environment. Relying on CI for compilation.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TVes4otYKR6fj4dbo5sZhD
Generated by Claude Code