Raise HeadlessMC total test timeout - #107
Merged
Merged
Conversation
HeadlessMC defaults to a 5 minute total timeout when totalTimeout is unset, which the full game test run now exceeds, causing the server to be killed (exit 137) even though all tests passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FijMLTxvoihBnXk8pE2Z58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server game test job in https://github.com/CyclopsMC/packtests/actions/runs/37048838231/job/110976870166 failed with exit code 137 even though all 1669 game tests passed.
Cause: when
totalTimeoutis not set in the test file, HeadlessMC (2.8.0,CommandTest) caps the whole test at 5 minutes. The per-steptimeout: 600does not raise that cap. The run took about 6.5 minutes, so the test was marked failed at 5:00 (CommandTest failed! Message: null). After a failure HeadlessMC waits 2 minutes for the process to exit and then callsdestroyForcibly(). The server was still shutting down afterstopat that point, so it got SIGKILLed (137).Changes:
mc-server-test.json: settotalTimeoutto 840s.gametests.yml: raise the server test steptimeout-minutesfrom 10 to 20. That covers 840s plus HeadlessMC's 2 minute kill grace period, so a real HeadlessMC timeout still shows its own error instead of being cut off by Actions.🤖 Generated with Claude Code
https://claude.ai/code/session_01FijMLTxvoihBnXk8pE2Z58
Generated by Claude Code