job-store-service: count each delivered data chunk once (DI-3049) - #322
Merged
jbndbc merged 1 commit intoSep 16, 2026
Conversation
chunkDeliveringDone is called again by every redelivery, and the broker's failure detection can produce two genuinely concurrent calls for one chunk, so the count of a job's delivered data chunks has to hang off something only one caller can do. DependencyTrackingService.remove now returns the removed entry rather than void, and the gate is advanced only by the caller that was handed one. IMap.remove is atomic per key, so of any number of concurrent callers exactly one gets the entry and the rest get null.
ja7
approved these changes
Sep 14, 2026
jbndbc
merged commit Sep 16, 2026
16af39f
into
DBCPR-328-dataio-chunk-scheduling-redesign
1 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chunkDeliveringDone is called again by every redelivery, and the broker's failure detection can produce two genuinely concurrent calls for one chunk, so the count of a job's delivered data chunks has to hang off something only one caller can do. DependencyTrackingService.remove now returns the removed entry rather than void, and the gate is advanced only by the caller that was handed one. IMap.remove is atomic per key, so of any number of concurrent callers exactly one gets the entry and the rest get null.