You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
E2E: the forced-click guard test misses Force=true and passes when it reads no files #645
#638 added a unit test, UnforcedClickTests, that fails if an E2E test forces a click, because a forced click can miss on a page that is still loading and fail with "Clicking the checkbox did not change its state".
The test has two gaps:
It looks only for the exact text Force = true, so Force=true or Force = true gets past it.
It passes if it finds no E2E test files at all, for example if the folder is moved, so it can pass without checking anything.
Fix
Match the option with any spacing, and still ignore Force = false.
Fail if the E2E test folder is missing or holds no test files.
Activity
Catch a forced click wrapped over several lines
645 Catch forced clicks in the E2E tests however they are spaced (#648)