Remove dead code - #710
Open
ecomodeller wants to merge 1 commit into
Open
Remove dead code#710ecomodeller wants to merge 1 commit into
ecomodeller wants to merge 1 commit into
Conversation
Nothing references any of this, and commented-out code is a claim that someone might want it back -- git history already keeps that promise. - utils: a 35-line commented-out get_item_name_and_idx, and is_iterable_not_str, which has no callers - TimeSeries._is_modelresult: no callers - settings: _describe_option, reachable only from a commented-out alias in a "temporary disabled" block that has outlived the temporary; is_callable and is_nonnegative, the two validators in the family nothing registers - ComparerCollection._unit_text: a commented-out consistency check - Comparer: commented-out gtype asserts, and start/end properties renamed to start_time/end_time long ago - SkillArrayPlotter: a commented-out map() behind a "hide this for now" PlotlyTimeSeriesPlotter is also unreferenced but stays -- #701 builds on it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unreferenced functions and commented-out blocks, found with vulture and verified by hand against
src,tests,docsandnotebooks.utils— a 35-line commented-outget_item_name_and_idx, andis_iterable_not_str, which has no callers.TimeSeries._is_modelresult— no callers.settings—_describe_option, reachable only from a commented-out alias inside a# temporary disabledblock that has outlived the temporary; plusis_callableandis_nonnegative, the two members of the validator family that nothing registers (is_positive,is_dictand the rest stay).ComparerCollection._unit_text— a commented-out consistency check.Comparer— commented-outgtypeasserts, andstart/endproperties renamed tostart_time/end_timelong ago.SkillArrayPlotter— a commented-outmap()behind a "hide this for now until we are certain about the API".PlotlyTimeSeriesPlotteris unreferenced too, but stays: #701 builds on it.Commented-out code is a claim that someone might want it back. Git history already keeps that promise.
🤖 Generated with Claude Code