Update DOMPurify by overriding version used by Mirador - #6233
Open
tdonohue wants to merge 1 commit into
Open
Conversation
tdonohue
added
dependencies
tdonohue
changed the title
tdonohue
changed the title
tdonohue
added
port to dspace-9_x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the version of
dompurifyused by Mirador by overriding the value (in theoverridessection ofpackage.json). Bumpsdompurifyfrom v2.5.8 to v3.4.15This major upgrade to v3 moves us to a version of
dompurifythat has much fewer vulnerability warnings (as v2 has a larger number of potential vulnerabilities).However, from my testing, this major upgrade to
dompurifyis still compatible with Mirador v3 becausedompurifyis only used in a few places to sanitize the HTML in Mirador.Instructions for Reviewers