Repository navigation
Fix importing CVAT image XML files with annotation_type="cvat" - #728
Conversation
The "cvat" import path sent every non-directory path to load_cvat_from_zip, so a plain annotations.xml failed with BadZipFile. "cvat_video" already routed .zip and .xml files correctly, so both types now share that branch.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description check |  |
The description clearly explains the CVAT XML import failure, the routing fix, related behavior, and test coverage. It is directly related to the changeset. |
| Title check | |
The title clearly and concisely identifies the primary change: fixing CVAT image XML imports when using annotation_type="cvat". |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks the CVAT trail
XML and ZIP now tell the tale
Images hop to img.jpg
Video flags appear when fit
Shared loaders keep paths neat
Tests thump out a steady beat
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: CHILL
- Plan: Essentials
- Run ID:
df6ca061-0b08-4869-bbff-5ea10a018754
📒 Files selected for processing (2)
dagshub/data_engine/annotation/importer.pytests/data_engine/annotation_import/test_cvat.py
Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.
📜 Review details
⏰ Context from checks skipped due to timeout. (7)
- GitHub Check: build (3.10)
- GitHub Check: Build documentation
- GitHub Check: build (3.13)
- GitHub Check: build (3.12)
- GitHub Check: build (3.9)
- GitHub Check: build (3.11)
- GitHub Check: Run linters
is_video_format only looked at the annotation type, so a "cvat" import of a CVAT video export went to the image task conversion. The importer now remembers when the CVAT loader returns video data.
Summary
ds.import_annotations_from_files(annotation_type="cvat", path="annotations.xml", ...)failed withzipfile.BadZipFile. The"cvat"branch ofAnnotationImporterpassed every path that isn't a directory toload_cvat_from_zip. The"cvat_video"branch already sends.zipfiles toload_cvat_from_zipand other files toload_cvat_from_xml_file, and it already handles both image and video results. Both types now share that branch.Related
CVAT brush masks (
<mask>) still import as empty until the converter adds mask support (DagsHub/dagshub-annotation-converter#29). After that is released, users get mask support by upgradingdagshub-annotation-converter.Testing
tests/data_engine/annotation_import/test_cvat.pyimports a CVAT image export as a.xmlfile and as a.zip. The.xmlcase fails without this fix.tests/data_engine/annotation_import: 76 passed.