Atomic handling fix - #69
Merged
Merged
Conversation
Static and constexpr data members are declared inside a struct or class, but they have no storage there and are not part of its layout. C++ debug info describes them as DW_TAG_member with DW_AT_declaration, e.g. "static constexpr bool is_always_lock_free" in std::atomic, which also carries DW_AT_const_expr and DW_AT_const_value. Previously these were loaded as regular members at offset 0 (default), so a2ltool would create a MEASUREMENT or CHARACTERISTIC for a value that doesn't exist in memory.
Both structs and classes can have base classes in C++, and the debug info describes them in exactly the same way. The previous model where struct had members but no inheritance was broken. Now DbgDataType::Struct and DbgDataType::Class have been combined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static and constexpr data members are declared inside a struct or class,
but they have no storage there and are not part of its layout. C++ debug
info describes them as DW_TAG_member with DW_AT_declaration, e.g.
"static constexpr bool is_always_lock_free" in std::atomic, which also
carries DW_AT_const_expr and DW_AT_const_value.
Previously these were loaded as regular members at offset 0 (default),
so a2ltool would create a MEASUREMENT or CHARACTERISTIC for a value that
doesn't exist in memory.
Both structs and classes can have base classes in C++, and the debug info
describes them in exactly the same way.
The previous model where struct had members but no inheritance was broken.
Now DbgDataType::Struct and DbgDataType::Class have been combined.
Fixes #68