Repository navigation
Conversation
…their own module The $.Actions validation, JSON round-trip checks and $.Actions proxy move to local-execution-shared.ts, unchanged, so a separate process can bundle them without local-execution.ts's import-time globalThis.$ accessor. The proxy takes a dispatch callback, so its caller decides where a call goes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 144ff8a | Docs | View more details | Give us feedback! |
|
@codex review |
There was a problem hiding this comment.
🟢 Approval recommended
The focused extraction preserves validation, serialization, and dispatch behavior, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Extracts reusable local-execution helpers into a side-effect-free module, preparing for sandboxed backend calls without changing current behavior.
Changes:
- Moves action validation, JSON checks, and proxy creation into a shared module.
- Injects a dispatch callback while preserving existing in-process execution.
| File | Description |
|---|---|
packages/plugins/apps/src/vite/local-execution.ts |
Imports shared helpers and supplies guarded dispatch. |
packages/plugins/apps/src/vite/local-execution-shared.ts |
Exports reusable helpers without installing the global $ accessor. |
Review effort: Balanced
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Motivation
$.Actionsvalidation, JSON checks and$.Actionsproxy live inlocal-execution.ts, which installs aglobalThis.$accessor when it's imported.Changes
3 changes across local-execution-shared.ts and local-execution.ts
$.Actionsvalidation,serializeActionInputs,assertJsonRoundTrippableandmakeActionsProxy, unchanged, into a module with no import-time side effects.local-execution-shared.tsmakeActionsProxytakes a dispatch callback, so its caller decides where a call goes.local-execution-shared.tslocal-execution.tsQA Instructions
TMPDIR=/private/tmpis only for the macOS manifest-tags and parameters suites, which fail under/var/foldersonmastertoo.Blast Radius
local-execution.tsimports the moved code, and its tests run unchanged.Documentation
🤖 Generated with Claude Code