Repository navigation
Conversation
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 95492e6 | Docs | View more details | Give us feedback! |
tyffical
changed the base branch from
tiffany.trinh/apps-2947-debug-bundle-connection-ids
to
tiffany.trinh/apps-2958-debug-bundle-call-inputs
October 22, 2026 00:29
tyffical
force-pushed
the
tiffany.trinh/apps-2958-frame-keepalive
branch
from
October 22, 2026 19:42
b10e989 to
3e2ee44
Compare
tyffical
force-pushed
the
tiffany.trinh/apps-2958-debug-bundle-call-inputs
branch
from
October 23, 2026 05:20
768c620 to
7e7153c
Compare
tyffical
force-pushed
the
tiffany.trinh/apps-2958-frame-keepalive
branch
from
October 23, 2026 05:20
3e2ee44 to
472048d
Compare
tyffical
force-pushed
the
tiffany.trinh/apps-2958-debug-bundle-call-inputs
branch
from
October 23, 2026 14:53
7e7153c to
2806fd6
Compare
tyffical
force-pushed
the
tiffany.trinh/apps-2958-frame-keepalive
branch
from
October 23, 2026 14:53
472048d to
5b44ed1
Compare
tyffical
force-pushed
the
tiffany.trinh/apps-2958-debug-bundle-call-inputs
branch
from
October 23, 2026 15:59
2806fd6 to
1d9a0d3
Compare
tyffical
force-pushed
the
tiffany.trinh/apps-2958-frame-keepalive
branch
from
October 23, 2026 15:59
5b44ed1 to
182ea03
Compare
The parent can post app-builder:run-query:keepalive with a pending call's requestId to restart the frame's 2-minute wait, for example every 30 seconds while a consent dialog is open. A keepalive counts only from the recipient a response would be accepted from, and a call still times out 60 minutes after it was posted. The cap is a safety net for a parent that keeps a call alive but never answers, not a deadline for the user reading a consent dialog. Both limits are wall-clock deadlines checked whenever the timer fires or a keepalive arrives, so time the machine spends asleep counts toward them. The dev client also learns the parent's origin from a keepalive, as it does from a pong or response. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tyffical
force-pushed
the
tiffany.trinh/apps-2958-debug-bundle-call-inputs
branch
from
October 23, 2026 16:22
1d9a0d3 to
7649b0d
Compare
tyffical
force-pushed
the
tiffany.trinh/apps-2958-frame-keepalive
branch
from
October 23, 2026 16:22
182ea03 to
95492e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Architecture
sequenceDiagram participant F as Frame (app) participant P as Parent page F->>P: app-builder:run-query, requestId Note over F: 2-minute wait and 60-minute cap start P->>F: app-builder:run-query:keepalive, same requestId Note over F: 2-minute wait restarts, cap unchanged P->>F: app-builder:run-query:response, same requestId Note over F: call settles, timers clearedrequestId.POSTMESSAGE_MAX_WAIT_MS(60 minutes) is a safety net for a parent that never answers, not a deadline for the user. Both limits are wall-clock deadlines, so time the machine spends asleep counts toward them.Changes
7 changes across protocol.ts, the postMessage transport, the dev client, test helpers and the README
app-builder:run-query:keepalivemessage typepackages/plugins/apps/src/backend/protocol.tsPOSTMESSAGE_MAX_WAIT_MSpackages/plugins/apps/src/backend/client/transports/post-message-transport/post-message-transport.tsIframeQueryKeepAlivetypepackages/plugins/apps/src/backend/client/transports/post-message-transport/types.tspackages/plugins/apps/src/backend/client/dev-client/dev-client.tskeepAlive()to the shared fake windowpackages/tests/src/_jest/helpers/fakeWindow.ts'*'posts, wrong source, wrong origin, unknown id, after reply, sleep, the cap and origin learningpost-message-transport.test.ts,dev-client.test.tspackages/plugins/apps/README.mdQA Instructions
Fail-before
Blast Radius
Out of Scope / Follow-ups
1 item deferred
Documentation
🤖 Generated with Claude Code