Repository navigation
RUM-19326: Fix flaky baggage header test - #4052
Merged
Merged
Conversation
The test forged a random RUM session id while the interceptor samples at 50%, so about half of the runs took the sampled-out path, where the baggage header is not injected. Pin the session id to SAMPLED_IDS, as the sibling sampling tests do. Ref: RUM-19326
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 9539b74 | Docs | View more details | Give us feedback! |
satween
marked this pull request as ready for review
October 27, 2026 13:54
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kikoveiga
approved these changes
Oct 27, 2026
ambushwork
approved these changes
Oct 27, 2026
![datadog-prod-us1-6[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
There was a problem hiding this comment.
More details
Selecting a known sampled session ID removes the random sampling outcome while preserving the baggage-header assertions for account, user, and session IDs.
🤖 Bits Code Review · Commit 9539b74
0xnm
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Pins the RUM session id in
RumContextPropagationTest.M send rum sessionId in baggage header W call is madetoSAMPLED_IDS, as the sibling sampling tests do.Motivation
The test is flaky on
develop(~32% failure rate in Flaky Test Management), failing withExpecting actual not to be null.Since #4027 the test forges a random session id, while the interceptor samples at 50%. About half of the runs take the sampled-out path (
setSampledOutHeaders), where thebaggageheader is not injected.Additional Notes
The iOS SDK injects
baggagefor sampled-out requests too; Android does not. That is a behavior change and is out of scope here.Verified locally: the test class passes on repeated runs, and the test fails when the session id is taken from
DROPPED_IDS.Review checklist (to be filled by reviewers)