Repository navigation
Fix feature registration test name collisions - #4064
Merged
1 commit merged intoOct 29, 2026
Merged
1 commit merged into
1 commit merged into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Give multi-feature tests unique names and verify concurrent registrations finish before checking the retrieved instances.
kikoveiga
force-pushed
the
kikoveiga/rum-18189/fix-feature-registration-test
branch
from
October 28, 2026 18:07
f63e773 to
0cba3f5
Compare
There was a problem hiding this comment.
More details
Indexed feature names eliminate collisions within each test’s registration list, and an unsuccessful registration wait now fails the concurrency test before retrieval. The completed static review identified no actionable defects.
🤖 Bits Code Review · Commit f63e773
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 0cba3f5 | Docs | View more details | Give us feedback! |
0xnm
approved these changes
Oct 29, 2026
jonathanmos
approved these changes
Oct 29, 2026
e77c5d8
aleksandr-gringauz
deleted the
kikoveiga/rum-18189/fix-feature-registration-test
branch
October 29, 2026 10:21
romtsn
pushed a commit
to romtsn/dd-sdk-android
that referenced
this pull request
Nov 2, 2026
…feature-registration-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Random feature names can collide. Because the SDK registers features by name, one feature replaces another and the test reports a missing instance. Forge seed
91reproduces the failure with two features namedb.Production behavior is unchanged.
Additional Notes
91and the fixed test passes; the temporary seed override was removed.develop.ktlintFormatAll, the module's unit-test task, and the Foundation gate passed. The module has no JVM unit tests.Review checklist (to be filled by reviewers)