Skip to content

Fix feature registration test name collisions - #4064

Merged
1 commit merged into
developfrom
kikoveiga/rum-18189/fix-feature-registration-test
Oct 29, 2026
Merged

1 commit merged into
developfrom
kikoveiga/rum-18189/fix-feature-registration-test

Conversation

@kikoveiga

@kikoveiga kikoveiga commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

What does this PR do?

  • Give the sequential and concurrent multi-feature registration tests unique feature names.
  • Exercise at least two concurrent registrations and assert that all threads finish before checking the retrieved instances.

Motivation

Random feature names can collide. Because the SDK registers features by name, one feature replaces another and the test reports a missing instance. Forge seed 91 reproduces the failure with two features named b.

Production behavior is unchanged.

Additional Notes

  • Verified that the original test fails with seed 91 and the fixed test passes; the temporary seed override was removed.
  • All 81 core integration tests passed on Android 17 / API 37, including on the standalone branch based on develop.
  • ktlintFormatAll, the module's unit-test task, and the Foundation gate passed. The module has no JVM unit tests.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@kikoveiga
kikoveiga requested review from a team as code owners October 28, 2026 18:05
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T18:08:48.249830Z 0cba3f5 New commits
🔒 Security Review ✅ Completed 2026-10-28T18:09:13.426672Z 0cba3f5 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Give multi-feature tests unique names and verify concurrent registrations
finish before checking the retrieved instances.
@kikoveiga
kikoveiga force-pushed the kikoveiga/rum-18189/fix-feature-registration-test branch from f63e773 to 0cba3f5 Compare October 28, 2026 18:07
@kikoveiga kikoveiga changed the title RUM-18189: Fix feature registration test name collisions Fix feature registration test name collisions Oct 28, 2026

@datadog-prod-us1-6 datadog-prod-us1-6 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

Indexed feature names eliminate collisions within each test’s registration list, and an unsuccessful registration wait now fails the concurrency test before retrieval. The completed static review identified no actionable defects.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit f63e773

@kikoveiga kikoveiga added the ready-for-human-review All agentic review feedback was addressed and PR is ready for the human review. label Oct 28, 2026
@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 71.86% (+0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0cba3f5 | Docs | View more details | Give us feedback!

@aleksandr-gringauz aleksandr-gringauz closed this pull request by merging all changes into develop in e77c5d8 Oct 29, 2026
@aleksandr-gringauz
aleksandr-gringauz deleted the kikoveiga/rum-18189/fix-feature-registration-test branch October 29, 2026 10:21
romtsn pushed a commit to romtsn/dd-sdk-android that referenced this pull request Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human-review All agentic review feedback was addressed and PR is ready for the human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants