Skip to content

RUM-19405: Improve Gradle setup - #4069

Open
0xnm wants to merge 1 commit into
developfrom
nogorodnikov/rum-19405/improve-gradle-setup
Open

0xnm wants to merge 1 commit into
developfrom
nogorodnikov/rum-19405/improve-gradle-setup

Conversation

@0xnm

@0xnm 0xnm commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

What does this PR do?

Improve some things in our Gradle setup:

  • Use pluginManagement and dependencyResolutionManagement only for the repositories declaration. To support code-sharing there is a little trick: a tiny Java-only (so that Gradle doesn't need to pull Kotlin) module which can be wired as included build.
  • Don't add Maven Central repo fallback if there is Depot declaration.
  • Remove some dependsOn with task name in favor of explicit output dependency.
  • Don't call .get on the dependency provider when it can be avoided.
  • Declare unmock in pluginManagement instead of adding it to the buildscript classpath manually.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 0.00%
• Overall Coverage: 72.02% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 17afe35 | Docs | View more details | Give us feedback!

@0xnm

0xnm commented Oct 29, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T15:33:14.406398Z 17afe35 New commits
🔒 Security Review ✅ Completed 2026-10-29T15:33:54.854348Z 17afe35 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 6850c586e2

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 6850c586e2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@0xnm
0xnm force-pushed the nogorodnikov/rum-19405/improve-gradle-setup branch from 6850c58 to 02c5774 Compare October 29, 2026 13:00
@0xnm
0xnm marked this pull request as ready for review October 29, 2026 13:19
@0xnm
0xnm requested review from a team as code owners October 29, 2026 13:19

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The static review raised no reportable defects in repository resolution, included-build setup, plugin migration, or task dependency wiring. Gradle configuration and dependency resolution remain unverified by execution.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 02c5774

@0xnm
0xnm force-pushed the nogorodnikov/rum-19405/improve-gradle-setup branch from 02c5774 to 17afe35 Compare October 29, 2026 15:29
@0xnm
0xnm added this pull request to stack #4077 October 29, 2026 15:36
@0xnm 0xnm added the ready-for-human-review All agentic review feedback was addressed and PR is ready for the human review. label Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human-review All agentic review feedback was addressed and PR is ready for the human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant