Repository navigation
RUM-18975: Stabilize fragment tracking test navigation - #4078
Conversation
Navigate pages without smooth scrolling and inspect fragments on the main thread to reduce timing dependencies in the integration test. Ref: RUM-18975
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
⏳ PR checks are still running. This summary will update when all results arrive. 🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: d308b90 | Docs | View more details | Give us feedback! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d308b90a92
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d308b90a92
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
aleksandr-gringauz
added
the
ready-for-human-review
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
There was a problem hiding this comment.
More details
Direct, non-animated ViewPager navigation preserves the fragment-tracking scenario while removing injected taps. Its effect on API 37 flakiness remains unverified because instrumented tests were not run.
🤖 Bits Code Review · Commit d308b90
|
ok, the job ran successfully 2 times without failures, merging.... |
What does this PR do?
Basically instead of tapping on a button to switch the viewpager tab, we are calling the viewpager directly.
According to the agent the number of test failures of this particular test increased after my PR, but ONLY on API 37. On older APIs there is no regression for some reason.
For now just trying to stabilize if we can.
Motivation
Additional Notes
Review checklist (to be filled by reviewers)