Skip to content

DO NOT MERGE - #12108

Draft
AlexeyKuznetsov-DD wants to merge 36 commits into
masterfrom
alexeyk/fix-v1-span-events-json-encoding-v1-default
Draft

AlexeyKuznetsov-DD wants to merge 36 commits into
masterfrom
alexeyk/fix-v1-span-events-json-encoding-v1-default

Conversation

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor

DO NOT MERGE, just for testing

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Jul 29, 2026
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added tag: do not merge Do not merge changes comp: core Tracer core tag: no release notes Changes to exclude from release notes labels Jul 29, 2026
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 0.98%
• Overall Coverage: 59.41% (-0.43%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: cc5be54 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.74 s 14.56 s [+0.5%; +2.1%] (maybe worse)
startup:insecure-bank:tracing:Agent 13.57 s 13.61 s [-1.1%; +0.5%] (no difference)
startup:petclinic:appsec:Agent 17.03 s 17.03 s [-1.2%; +1.2%] (no difference)
startup:petclinic:iast:Agent 16.93 s 16.90 s [-0.5%; +0.9%] (no difference)
startup:petclinic:profiling:Agent 16.47 s 16.73 s [-2.6%; -0.4%] (maybe better)
startup:petclinic:sca:Agent 17.02 s 16.93 s [-0.4%; +1.5%] (no difference)
startup:petclinic:tracing:Agent 16.10 s 16.08 s [-0.6%; +0.8%] (no difference)

Commit: cc5be542 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

# Conflicts:
#	dd-trace-core/src/test/java/datadog/trace/core/DDSpanSerializationTest.java
AlexeyKuznetsov-DD and others added 12 commits September 18, 2026 11:17
SpanV1 skipped the span events field, so spans decoded from v1 payloads
lost their events, and the blind skip consumed streaming strings without
registering them, desynchronizing the string table. Decode the events
through the table-aware helpers into the same events meta tag the tracer
writes for v0.4, so both protocols decode to the same tag.

Also split the JSON decoder span events precedence/empty test into
focused tests.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: core Tracer core tag: do not merge Do not merge changes tag: no release notes Changes to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant