Repository navigation

Split TagMap into id and name stores, owned directly by the span - #12918

Closed

dougqh wants to merge 125 commits into

masterfrom

dougqh/tagmap-split-stores

Closed

Split TagMap into id and name stores, owned directly by the span#12918
dougqh wants to merge 125 commits into
masterfrom
dougqh/tagmap-split-stores

Commits on Oct 9, 2026
- Set known tags by id on TagMap and spans
  dougqh
  committed
  3ab5862
- Ignore unknown ids when clearing a tag by id; fix a comment wrap
  
  dougqh
  and
  claude
  committed
  4bf02bb
- Precheck and reuse the box in long-valued setters
  
  dougqh
  and
  claude
  committed
  a2829d1
- Keep peer.port off the id path
  
  dougqh
  and
  claude
  committed
  2d87cde
- Merge set-by-id (#12715) onto master
  dougqh
  committed
  7a017a5
- Mark intercepted tags with an id bit, via a tracer overlay
  
  dougqh
  and
  claude
  committed
  0401a43
- Dispatch TagInterceptor on tag ids
  
  dougqh
  and
  claude
  committed
  8949a57
- Set tags on spans by id first
  
  dougqh
  and
  claude
  committed
  cfe2368
- Look up tag names by serial in an array, not a switch
  
  dougqh
  and
  claude
  committed
  38c9947
- Point stale comments at the tracer overlay and the intercepted bit
  
  dougqh
  and
  claude
  committed
  3545c15
- Index the split-by-tags table by serial, sized to every known tag
  
  dougqh
  and
  claude
  committed
  1642cc9
- Check for a known tag id with a range check, not a name lookup
  
  dougqh
  and
  claude
  committed
  b9dd573
- Pin interceptTag(long) above C2's inlining size
  
  dougqh
  and
  claude
  committed
  75d3fbc
- Tighten comments on the id-keyed interceptor
  
  dougqh
  and
  claude
  committed
  ecb4f73
- Treat overlay tags as intercepted; tidy from review
  
  dougqh
  and
  claude
  committed
  3f65031
- Reject shared-name tag ids on the id-keyed TagMap and span paths
  
  dougqh
  and
  claude
  committed
  69d7849
- Test rejection of shared-name tag ids
  
  dougqh
  and
  claude
  committed
  46c3b47
Commits on Oct 10, 2026
- Build custom tags by name and known tags by id
  
  dougqh
  and
  claude
  committed
  ad2fa97
- Resolve direction-dependent tag names by the span's kind
  
  dougqh
  and
  claude
  committed
  3a269e1
- Key shared-name tags by direction now that resolution knows it
  
  dougqh
  and
  claude
  committed
  d509119
- Merge master into id-tag-interceptor (#12817)
  dougqh
  committed
  628da33
- Merge id-tag-interceptor (#12817) into tag-registry-direction-resolution
  dougqh
  committed
  cc43136
- Give the tracer core a restricted, trusted path into TagMap
  
  dougqh
  and
  claude
  committed
  dac7060
- Mark TagMap.Internals @NoEscape
  
  dougqh
  and
  claude
  committed
  fbab551
- Merge id-tag-interceptor (#12817) into tag-registry-direction-resolution
  dougqh
  committed
  8d47c7f
- Point Internals' trust note at isKnown, the span's check here
  
  dougqh
  and
  claude
  committed
  92fb191
Commits on Oct 13, 2026
- Store each direction-dependent tag once and apply direction on read
  
  dougqh
  and
  claude
  committed
  06dec0f
- Name direction-dependent tags by span kind in OTLP export
  
  dougqh
  and
  claude
  committed
  d469c66
- Apply last write wins between a tag and its direction-scoped alias
  
  dougqh
  and
  claude
  committed
  748a8af
- Carry the direction role in tag ids so plain setTag pays nothing extra
  
  dougqh
  and
  claude
  committed
  44826c6
- Move alias superseding off the setTag store fast path
  
  dougqh
  and
  claude
  committed
  dc06725
- Cover SpanTags and the KnownTagCodec direction helpers in internal-api
  
  dougqh
  and
  claude
  committed
  44c9c2f
- Route alias-target writes only on spans holding a pending alias
  
  dougqh
  and
  claude
  committed
  d3d6ee4
- Merge tag-registry-direction-resolution into the single-representation rework
  dougqh
  committed
  a48e145
- Cover the remaining TagMap.Internals setKnown overloads
  
  dougqh
  and
  claude
  committed
  85c222d
- Add datadog.apicontract to CODEOWNERS
  
  dougqh
  and
  claude
  committed
  f08c1c3
- Merge branch 'master' into dougqh/id-tag-interceptor
  dougqh
  authored
  f796149
- Give peer.port one direction-neutral id
  
  dougqh
  and
  claude
  committed
  22d0fd1
- Name peer.port by the span's kind in OTLP export
  
  dougqh
  and
  claude
  committed
  ba715de
- Merge id-tag-interceptor (#12817, before the peer.port move) into tag-registry-direction-resolution
  
  dougqh
  and
  claude
  committed
  e55a358
- Merge id-tag-interceptor (#12817) into tag-registry-direction-resolution
  
  dougqh
  and
  claude
  committed
  01ea7f5
- Let C2 inline the constructors of TagMap's nested classes
  
  dougqh
  and
  claude
  committed
  584310c
- Remove TagMap's remaining synthetic accessors and guard against them
  
  dougqh
  and
  claude
  committed
  3842b16
- Merge id-tag-interceptor (#12817) into tag-registry-direction-resolution
  
  dougqh
  and
  claude
  committed
  6e6077e
Commits on Oct 14, 2026
- Merge master into id-tag-interceptor
  
  dougqh
  and
  claude
  committed
  64d6cf3
- Cover TagMap.Internals, KnownTagCodec and EntryReader paths
  
  dougqh
  and
  claude
  committed
  bb0bbb0
- Format the tag-registry generator to its spotless rules
  
  dougqh
  and
  claude
  committed
  fb6410e
- Merge id-tag-interceptor (#12817) into tag-registry-direction-resolution
  
  dougqh
  and
  claude
  committed
  6593371
- Drop #12817's direction stand-in tests, covered by SpanTagsTest
  
  dougqh
  and
  claude
  committed
  0d7b732
- Order the tag-id carve bits by position
  
  dougqh
  and
  claude
  committed
  97a508b
- Merge master into id-tag-interceptor
  
  dougqh
  and
  claude
  committed
  fa54aca
- Merge id-tag-interceptor (#12817) into tag-registry-direction-resolution
  
  dougqh
  and
  claude
  committed
  4bb2c75
- Re-apply split-by-tags language by its id
  
  dougqh
  and
  claude
  committed
  1c88d5e
- Say what a tag id's intercepted bit does and doesn't decide
  
  dougqh
  and
  claude
  committed
  5ba0a09
Commits on Oct 15, 2026
- Merge #12817's final commits into tag-registry-direction-resolution
  dougqh
  committed
  1a084b2
- Merge remote-tracking branch 'origin/master' into dougqh/tag-registry-direction-resolution
  dougqh
  committed
  a24cb0d
- Restore the conventions' one-tag wording for peer.port
  
  dougqh
  and
  claude
  committed
  32ad2a3
- Tidy the direction-resolution code from review
  
  dougqh
  and
  claude
  committed
  306b312
- Keep the alias slow paths to spans that really hold a pending alias
  
  dougqh
  and
  claude
  committed
  96df27a
- Make a removal before the span's kind supersede every meaning
  
  dougqh
  and
  claude
  committed
  a5c6556
- Extend the pending-alias gate to reads, removals and entry routing
  
  dougqh
  and
  claude
  committed
  d7356bc
- Encapsulate direction handling in a package-private DirectionalTags
  
  dougqh
  and
  claude
  committed
  c517b18
Commits on Oct 16, 2026
- Write and read known tags by id without building an Entry per call
  
  dougqh
  and
  claude
  committed
  ab4b1ac
- Resolve aliases when the kind is set, and route them as their tag
  
  dougqh
  and
  claude
  committed
  351145d
- Close three more gaps between the write paths and direction handling
  
  dougqh
  and
  claude
  committed
  6aa6d4f
- Split TagMap into a view over an id store and a name store
  
  dougqh
  and
  claude
  committed
  1c92947
- Route TagMap's name-keyed operations through one resolver
  
  dougqh
  and
  claude
  committed
  4d6f7d0
- Clarify what the store split costs and where a dense mode would plug in
  
  dougqh
  and
  claude
  committed
  d2261f3
- Let the span own its tag stores and route to them directly
  
  dougqh
  and
  claude
  committed
  e605c60
- Add a benchmark of reading tags back from a live span
  
  dougqh
  and
  claude
  committed
  7d80723
- Copy tracer-level tags into a span's store without a view
  
  dougqh
  and
  claude
  committed
  5f7458b
- Cache the span's view of its tag stores
  
  dougqh
  and
  claude
  committed
  ac7a00d
- Keep a span's pending aliases in their own holder
  
  dougqh
  and
  claude
  committed
  2d0ef38
- Color known tags into co-occurrence slots in their ids
  
  dougqh
  and
  claude
  committed
  f7999bd
- Treat a custom tag's zero id as unslotted
  
  dougqh
  and
  claude
  committed
  0475a1f
- Say a slot bit is only a may-be-present signal
  
  dougqh
  and
  claude
  committed
  8ed88c9
- Give known and custom tags separate hash stores
  
  dougqh
  and
  claude
  committed
  31bf06e
- Measure a read of a known tag the span doesn't hold
  
  dougqh
  and
  claude
  committed
  d147b3d
- Let the span use its tag stores directly again
  
  dougqh
  and
  claude
  committed
  023313b
- Note why the span's custom-store flag needs no volatile
  
  dougqh
  and
  claude
  committed
  cd501d5
- Register the tracer's root-span tags as known tags
  
  dougqh
  and
  claude
  committed
  08d769f
- Pass DirectionalTags the span's stores instead of the span
  
  dougqh
  and
  claude
  committed
  aa324be
- Let a Datadog tag name double as another tag's direction-scoped alias
  
  dougqh
  and
  claude
  committed
  dabddda
- Drop the OTLP export check for a tag written by id on the wrong side
  
  dougqh
  and
  claude
  committed
  b1107a3
- Keep pending aliases out of TagInterceptor
  
  dougqh
  and
  claude
  committed
  1bf3e28
- Hand the span's view its direction instead of the span
  
  dougqh
  and
  claude
  committed
  3b9cc8d
- Merge remote-tracking branch 'origin/master' into dougqh/tag-registry-direction-resolution
  dougqh
  committed
  66a069c
- Resolve direction-scoped names at the OpenTelemetry boundary, not in the core
  
  dougqh
  and
  claude
  committed
  d7f0ffc
- Look up known tags by id, not by name, in the id store
  
  dougqh
  and
  claude
  committed
  f746fbe
- Average known-tag reads over the span's tags in GetTagBenchmark
  
  dougqh
  and
  claude
  committed
  2d56d29
- Return EntryReader from IdStore's point operations
  
  dougqh
  and
  claude
  committed
  7547659
- Generate a serial-to-id table so a store can keep only the serial
  
  dougqh
  and
  claude
  committed
  df09039
- Add a dense id store behind an experimental flag
  
  dougqh
  and
  claude
  committed
  a31a1de
Commits on Oct 17, 2026
- Read a root span's trace-level tags through one shared parent
  
  dougqh
  and
  claude
  committed
  462f753
- Keep span-level and trace-level slot bits apart with a level set
  
  dougqh
  and
  claude
  committed
  634e880
- Merge #12731: direction handling moves to the OpenTelemetry boundary
  
  dougqh
  and
  claude
  committed
  463ffb2
- Address review: IdStore naming, EntryReader puts, member order
  
  dougqh
  and
  claude
  committed
  030fc85
- Clarify comments touched by the store split
  
  dougqh
  and
  claude
  committed
  6bcd11f
- Rename newEmpty to createEmpty
  
  dougqh
  and
  claude
  committed
  4e6ead4
- Fold TagRouting into its users
  
  dougqh
  and
  claude
  committed
  4d77117
- Address review: knownTags, GuardedBy and the span's locking scheme
  
  dougqh
  and
  claude
  committed
  f634ec7
- Drop the span's cached view instead of re-attaching it
  
  dougqh
  and
  claude
  committed
  da19019
- Prefix the span's store-routing operations with route
  
  dougqh
  and
  claude
  committed
  9a5583f
- Fold EntryReadingHelper into the dense store's reader
  
  dougqh
  and
  claude
  committed
  2ed6e5f
- Rename TagMap's stores to knownStore and nameStore
  
  dougqh
  and
  claude
  committed
  a722412
- Drop two per-call allocations from the review
  
  dougqh
  and
  claude
  committed
  14f33ca
- Tidy the store split from review
  
  dougqh
  and
  claude
  committed
  334e26a
- Remove TagMap.getKnownValue
  
  dougqh
  and
  claude
  committed
  3a09000
- Fix misplaced and stale comments from review
  
  dougqh
  and
  claude
  committed
  fff066e
- Keep one occupancy word per level in the id store
  
  dougqh
  and
  claude
  committed
  0f1e5ac
Commits on Oct 19, 2026
- Merge master (#12882 slot coloring) into tag-registry-direction-resolution
  
  dougqh
  and
  claude
  committed
  416663b
- Merge tag-registry-direction-resolution (master's #12882) into tagmap-split-stores
  
  dougqh
  and
  claude
  committed
  77c7445
- Cover both id stores with a shared contract test
  
  dougqh
  and
  claude
  committed
  b306324
Commits on Oct 20, 2026
- Keep the no-entry reader no-op, and make makeTagId the real id
  
  dougqh
  and
  claude
  committed
  ac96cd7
- Give point reads their own Entry instead of the store's shared reader
  
  dougqh
  and
  claude
  committed
  eee2c9c
- Merge master (#12731, #12893) into dougqh/tagmap-split-stores
  
  dougqh
  and
  claude
  committed
  24a64df
- Read known tag values straight from the store in getObject and getString
  
  dougqh
  and
  claude
  committed
  018a273
- Add TagMap.getEntryReader and route the primitive getters through it
  
  dougqh
  and
  claude
  committed
  33badb1
- State EntryReader's momentary contract as a MUST, not a NoEscape SHOULD
  
  dougqh
  and
  claude
  committed
  f7cdf1c
Commits on Oct 21, 2026
- Add a whole-trace allocation benchmark for the tag stores
  
  dougqh
  and
  claude
  committed
  ffd6034
Commits on Oct 22, 2026
- Bucket known tags by slot in the hash stores
  
  dougqh
  and
  claude
  committed
  e08f46d
- Vary TraceShapeBenchmark's trace size
  
  dougqh
  and
  claude
  committed
  fd6f5c3
- Give TagMap's stream and spliterator stable entries
  
  dougqh
  and
  claude
  committed
  231ec97
- Merge remote-tracking branch 'origin/master' into dougqh/tagmap-split-stores
  dougqh
  committed
  0cdb5d6
- Make a null value remove the tag in TagMap and its stores
  
  dougqh
  and
  claude
  committed
  99c3321

Commits

Commits on Oct 9, 2026

Commits on Oct 10, 2026

Commits on Oct 13, 2026

Commits on Oct 14, 2026

Commits on Oct 15, 2026

Commits on Oct 16, 2026

Commits on Oct 17, 2026

Commits on Oct 19, 2026

Commits on Oct 20, 2026

Commits on Oct 21, 2026

Commits on Oct 22, 2026