Add experimental Datadog profiler option overrides by jbachorik · Pull Request #12983 · DataDog/dd-trace-java

jbachorik · 2026-10-21T14:06:24Z

What Does This Do

Adds dd.profiling.experimental.ddprof.options for selectively overriding Datadog Profiler arguments. Explicit keys replace conflicting derived options while other derived options remain unchanged. The agent-controlled action, output format, and recording path cannot be overridden.

Using the option emits a warning marked for telemetry.

Motivation

Allows experimental profiler options such as nativemem or reference-chains to easily check the experimental profiler features without building specific profiler experimental config keys in the tracer.

Additional Notes

Validation:

profiling-ddprof unit tests
profiling-ddprof Spotless check
configuration metadata checks

Contributor Checklist

Format the title according to the contribution guidelines
Assign the required labels
Add configuration metadata
Add comprehensive unit coverage

chatgpt-codex-connector · 2026-10-21T14:18:39Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-21T14:25:58.030979Z	`d336703`	Draft marked ready
🔒 Security Review	✅ Completed 2026-10-21T14:22:29.859396Z	`d336703`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d33670373a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

datadog-official · 2026-10-21T14:29:21Z

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.60% (-0.22%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 51efb8a | Docs | Give us feedback!}

dd-octo-sts · 2026-10-21T14:35:15Z

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	13.97 s	13.94 s	[-0.4%; +0.9%] (no difference)
startup:insecure-bank:tracing:Agent	12.83 s	12.99 s	[-2.0%; -0.5%] (maybe better)
startup:petclinic:appsec:Agent	17.11 s	16.44 s	[-0.4%; +8.7%] (no difference)
startup:petclinic:iast:Agent	16.92 s	17.02 s	[-1.4%; +0.2%] (no difference)
startup:petclinic:profiling:Agent	16.61 s	16.84 s	[-2.4%; -0.4%] (maybe better)
startup:petclinic:sca:Agent	16.99 s	16.70 s	[+0.9%; +2.6%] (maybe worse)
startup:petclinic:tracing:Agent	16.10 s	16.10 s	[-0.9%; +0.8%] (no difference)

Commit: 51efb8a2 · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

datadog-official

Experimental overrides can replace the protected start action, leaving recording state set without recording. Sampler overrides also leave controller modes stale, allowing overlapping native and JFR allocation sampling.

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit d336703}

kaahos

Thanks for the work! I've left some comments about potential corner cases.

jbachorik · 2026-10-22T11:22:57Z

@kaahos Well caught corner-cases! All fixed!

kaahos

looks good to me thanks!

jbachorik · 2026-10-22T15:27:21Z

/merge

dd-octo-sts · 2026-10-22T15:27:24Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-10-22T15:27:26Z

View all feedbacks in Devflow UI.

2026-10-22 15:27:25 UTC ℹ️ Start processing command /merge

2026-10-22 15:27:30 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-10-22 15:44:54 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 4fa7522:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

gh-worker-devflow-routing-ef8351 · 2026-10-22T15:27:28Z

View all feedbacks in Devflow UI.

2026-10-22 15:27:28 UTC ℹ️ Start processing command /merge

2026-10-22 15:27:30 UTC ❌ MergeQueue

PR already in the queue with status queued

dd-octo-sts · 2026-10-22T17:04:05Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-10-22T17:04:10Z

View all feedbacks in Devflow UI.

2026-10-22 17:04:09 UTC ℹ️ Start processing command /merge

2026-10-22 17:04:15 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-10-22 18:18:45 UTC ℹ️ MergeQueue: This merge request was merged

Add experimental Datadog profiler option overrides

d336703

jbachorik added type: feature Enhancements and improvements comp: profiling Profiling tag: ai generated Largely based on code generated by an AI or LLM labels Oct 21, 2026

jbachorik marked this pull request as ready for review October 21, 2026 14:18

jbachorik requested review from a team as code owners October 21, 2026 14:18

jbachorik requested review from dougqh and removed request for a team October 21, 2026 14:18

chatgpt-codex-connector Bot reviewed Oct 21, 2026

View reviewed changes

datadog-official Bot reviewed Oct 21, 2026

View reviewed changes

Comment thread ...t-profiling/profiling-ddprof/src/main/java/com/datadog/profiling/ddprof/DatadogProfiler.java Outdated

Comment thread ...t-profiling/profiling-ddprof/src/main/java/com/datadog/profiling/ddprof/DatadogProfiler.java

jbachorik added 2 commits October 21, 2026 16:38

Remove unintended async profiler option alias

ba89aa7

Harden experimental profiler option overrides

0e4f669

kaahos reviewed Oct 22, 2026

View reviewed changes

jbachorik and others added 2 commits October 22, 2026 14:00

Avoid forbidden regex option parsing

a47df9d

Handle profiler CPU option conflicts

c374493

jbachorik force-pushed the profiler-experimental-options branch from e707bb9 to c374493 Compare October 22, 2026 12:01

kaahos approved these changes Oct 22, 2026

View reviewed changes

jbachorik added this pull request to the merge queue Oct 22, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 22, 2026

Fix J9 wall default assumption in profiler options test

51efb8a

jbachorik enabled auto-merge October 22, 2026 16:11

jbachorik added this pull request to the merge queue Oct 22, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 22, 2026

gh-worker-dd-mergequeue-cf854d Bot merged commit e4d04b9 into master Oct 22, 2026
609 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the profiler-experimental-options branch October 22, 2026 18:18

github-actions Bot added this to the 1.68.0 milestone Oct 22, 2026

Conversation

jbachorik commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

chatgpt-codex-connector Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

datadog-official Bot commented Oct 21, 2026 • edited by datadog-prod-us1-5 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dd-octo-sts Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 Java Benchmark SLOs — All performance SLOs passed

Uh oh!

datadog-official Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kaahos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jbachorik commented Oct 22, 2026

Uh oh!

kaahos left a comment

Choose a reason for hiding this comment

Uh oh!

jbachorik commented Oct 22, 2026

Uh oh!

dd-octo-sts Bot commented Oct 22, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

dd-octo-sts Bot commented Oct 22, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jbachorik commented Oct 21, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 21, 2026 •

edited

Loading

datadog-official Bot commented Oct 21, 2026 •

edited by datadog-prod-us1-5 Bot

Loading

dd-octo-sts Bot commented Oct 21, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 22, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 22, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 22, 2026 •

edited

Loading