Skip to content

Enable dd-openfeature JAR comparison in CI - #12991

Closed
bric3 wants to merge 1 commit into
masterfrom
codex/enable-openfeature-jar-comparison
Closed

bric3 wants to merge 1 commit into
masterfrom
codex/enable-openfeature-jar-comparison

Conversation

@bric3

@bric3 bric3 commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

What Does This Do

Add dd-openfeature to the reference and failure artifacts in validate_build, then enable its compareToReferenceJar task.

Motivation

The build job already produces the jar, but validate_build does not preserve a reference copy.

Follow-up to

Additional Notes

The focused jar comparison passed locally using a copied reference jar.

Contributor Checklist

@bric3 bric3 added comp: openfeature OpenFeature type: feature Enhancements and improvements tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes labels Oct 22, 2026 — with ChatGPT Codex Connector
@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.86% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7befb5e | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.99 s 13.89 s [-0.0%; +1.6%] (no difference)
startup:insecure-bank:tracing:Agent 12.91 s 12.94 s [-1.0%; +0.4%] (no difference)
startup:petclinic:appsec:Agent 17.16 s 16.42 s [+0.3%; +8.7%] (maybe worse)
startup:petclinic:iast:Agent 17.01 s 17.02 s [-0.9%; +0.7%] (no difference)
startup:petclinic:profiling:Agent 16.75 s 16.96 s [-2.5%; +0.1%] (no difference)
startup:petclinic:sca:Agent 17.09 s 16.89 s [+0.3%; +2.0%] (maybe worse)
startup:petclinic:tracing:Agent 15.85 s 16.13 s [-5.9%; +2.4%] (no difference)

Commit: 7befb5e1 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@bric3
bric3 marked this pull request as ready for review October 22, 2026 11:56
@bric3
bric3 requested review from a team as code owners October 22, 2026 11:56
@bric3
bric3 requested review from PerfectSlayer and randomanderson and removed request for a team October 22, 2026 11:56
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T11:58:24.741003Z 7befb5e Draft marked ready
🔒 Security Review ✅ Completed 2026-10-22T12:00:49.041578Z 7befb5e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@PerfectSlayer PerfectSlayer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of #12844

@datadog-prod-us1-6 datadog-prod-us1-6 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The OpenFeature artifact paths match the JAR already produced by CI, allowing the enabled comparison task to locate its reference. No actionable defects were identified.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 7befb5e

@bric3

bric3 commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

Closing because duplicate of #12844 as @PerfectSlayer mentionned

@bric3 bric3 closed this Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: openfeature OpenFeature tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants