Repository navigation
Stop trusting compromised eMudhra roots in the exploration-tests image - #13026
Draft
eliottness wants to merge 1 commit into
Draft
eliottness wants to merge 1 commit into
eliottness wants to merge 1 commit into
Conversation
Upgrade ca-certificates in the debian:bookworm-slim base and delete emSign ECC Root CA - G3 / AAA Certificate Services from every SDKMAN and Gradle-provisioned JDK cacerts in the exploration-tests image (IR-62343). The image is published by the manual build-exploration-tests-image job; re-run it after merge. Jira: APPSEC-71277
Contributor
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Images used by this repository's CI still ship CA stores that trust emSign ECC Root CA - G3 and/or AAA Certificate Services, the roots behind the compromised eMudhra intermediates (incident IR-62343). The APPSEC-71273 ledger lists 17 impacted image references here. Images that CI never builds or pulls are left alone.
Changes
dd-java-agent/agent-debugger/exploration-tests/Dockerfile.exploration-testsVerification
Every new image reference and every changed Dockerfile was pulled or built and scanned with the eMudhra scanner (checks every file in the image for the roots' public keys); all return empty hits. Of the 17 impacted references: 0 fixed here, 1 fixed at their in-repo image source (clean once the image job republishes), 16 follow-ups below.
Follow-ups (not in this PR)
registry.ddbuild.io/images/mirror/amazon/aws-cli:2.4.29: DataDog/images mirror/amazon/aws-cli; upstream 2.38.5 still has seven affected paths and no 2.38.5 mirror tag exists.486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/benchmarking-platform:java-dsm-kafka: DataDog/benchmarking-platform branch java-dsm-kafka; source checkout is outside this lane.486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/benchmarking-platform:java-debugger: DataDog/benchmarking-platform branch java-debugger; source checkout is outside this lane.registry.ddbuild.io/images/mirror/dd-apm-test-agent/ddapm-test-agent:v1.64.1: DataDog/dd-apm-test-agent and DataDog/images mirror; mirrored v1.68.0 and upstream v1.69.0 each retain six affected paths.registry.ddbuild.io/images/mirror/datadog/agent:7.40.1: DataDog/datadog-agent and DataDog/images mirror; upstream 7.84.5 still embeds affected roots and its mirror tag is unavailable.registry.ddbuild.io/images/mirror/sqlserver:latest: DataDog/images mirror/sqlserver; current latest still has OS and embedded SQL certificate hits.registry.ddbuild.io/images/mirror/dd-trace-java-docker-build:ci-base: DataDog/images mirror/dd-trace-java-docker-build ci-base; patch OS, Python, bundled JDK, and datadog-ci stores.registry.ddbuild.io/images/mirror/dd-trace-java-docker-build:ci-7: DataDog/images mirror/dd-trace-java-docker-build ci-7; patch OS, Python, bundled JDK, and datadog-ci stores.registry.ddbuild.io/images/mirror/dd-trace-java-docker-build:ci-8: DataDog/images mirror/dd-trace-java-docker-build ci-8; patch OS, Python, bundled JDK, and datadog-ci stores.registry.ddbuild.io/images/mirror/dd-trace-java-docker-build:ci-11: DataDog/images mirror/dd-trace-java-docker-build ci-11; patch OS, Python, bundled JDK, and datadog-ci stores.registry.ddbuild.io/images/mirror/dd-trace-java-docker-build:ci-17: DataDog/images mirror/dd-trace-java-docker-build ci-17; patch OS, Python, bundled JDK, and datadog-ci stores.registry.ddbuild.io/images/mirror/dd-trace-java-docker-build:ci-21: DataDog/images mirror/dd-trace-java-docker-build ci-21; patch OS, Python, bundled JDK, and datadog-ci stores.gcr.io/google.com/cloudsdktool/google-cloud-cli:emulators: Current emulator test image still has 17 affected paths; upstream stable tag also has 12 vendored CA hits and cannot replace emulator tooling.mcr.microsoft.com/mssql/server:latest: Current latest SQL Server test target embeds affected certificates in system.certificates.sfp; needs patched upstream SQL Server image.486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/agent-key-management-tools/gpg:1: Error response from daemon: failed to resolve reference "486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/agent-key-management-tools/gpg:1": pull access denied, repository does not exist or may require authorization: authJira: APPSEC-71277 (parent APPSEC-71273)