Repository navigation
Use the mirrored Pub/Sub emulator image in CI - #13027
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The mirrored image selection remains compatible with the existing image resolver and Pub/Sub container setup. Container startup remains unverified.
🤖 Bits Code Review · Commit 7df3cb2
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
d1b9478
into
master
What Does This Do
Use
registry.ddbuild.io/images/mirror/google.com/cloudsdktool/google-cloud-cli:emulatorsfor the Pub/Sub emulator in CI. Keep the existing GCR image for local runs, following the existing SQL Server image-selection pattern in the JDBC module introduced in #12633 — Track Testcontainers images as Gradle test inputs. Both select an internal mirror whenCIis set and retain the upstream image for local runs.Motivation
Resolving the upstream image manifest can fail with HTTP 429 when Google's Artifact Registry request quota is exceeded. The explicit
gcr.iohost bypasses the Docker Hub mirror prefix, so declare the mirrored image directly in CI.Additional Notes
The mirror preserves the original upstream image and tag. Its live manifest digest was verified against the images repository lockfile:
sha256:cced7aefc06898a91efcfc942e6ab98537b3ec2d15d66ec54cffa62ac6d7f19b.Failure evidence:
Validation:
./gradlew :dd-java-agent:instrumentation:google-pubsub-1.116:latestDepTest :dd-java-agent:instrumentation:google-pubsub-1.116:latestDepForkedTest -PtestJvm=8; the run stopped during test initialization because no valid Docker environment was available. Runtime validation remains pending.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue