Skip to content

Request dependent flags with query parameter - #13226

Draft
typotter wants to merge 3 commits into
helen/dependent-flags-capabilities-javafrom
typo/dependent-flags-query-param-java
Draft

typotter wants to merge 3 commits into
helen/dependent-flags-capabilities-javafrom
typo/dependent-flags-query-param-java

Conversation

@typotter

@typotter typotter commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

What Does This Do

Uses cap_dependent-flags-variant-key=v1 on direct UFC requests when the evaluator reports dependent-flag support. Existing query parameters are preserved, and the dependent-flags capability header is no longer sent to UFC.

This is stacked on #13167 for an independently reviewable transport-only diff.

Motivation

Keep the capabilities header scoped to client SDK → Edge Assignments negotiation while direct UFC consumers negotiate response shape through the cache-keyed URL.

Additional Notes

The request-building unit coverage includes absent, unknown, and supported capabilities with an existing query parameter. ./gradlew :dd-openfeature:spotlessApply :dd-openfeature:test --tests '*CdnConfigurationSourceTest' --tests '*EvaluatorCapabilitiesTest' could not complete locally because the workspace filesystem filled while Gradle configured the repository (No space left on device); CI should run the scoped suite.

@typotter typotter added type: feature Enhancements and improvements tag: ai generated Largely based on code generated by an AI or LLM comp: openfeature OpenFeature labels Nov 4, 2026
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.68% (-1.64%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2cd5ba1 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.95 s 13.86 s [+0.1%; +1.2%] (maybe worse)
startup:insecure-bank:tracing:Agent 12.87 s 13.00 s [-1.6%; -0.3%] (maybe better)
startup:petclinic:appsec:Agent 17.24 s 17.09 s [-0.0%; +1.8%] (no difference)
startup:petclinic:iast:Agent 17.09 s 17.16 s [-1.1%; +0.2%] (no difference)
startup:petclinic:profiling:Agent 16.72 s 17.08 s [-3.5%; -0.8%] (maybe better)
startup:petclinic:sca:Agent 17.19 s 16.97 s [+0.4%; +2.1%] (maybe worse)
startup:petclinic:tracing:Agent 16.16 s 16.10 s [-0.6%; +1.4%] (no difference)

Commit: 2cd5ba1d · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: openfeature OpenFeature tag: ai generated Largely based on code generated by an AI or LLM type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant