Repository navigation
fix: native rust fix for HAMT/ContextVar crash - #18599
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
Conversation
01ffcf6 to
24eb7d0
Compare
|
Codeowners resolved as |
94735b4 to
1fa86bd
Compare
BenchmarksBenchmark execution time: 2026-06-23 14:33:06 Comparing candidate commit e0b4bb5 in PR branch Found 0 performance improvements and 5 performance regressions! Performance is the same for 613 metrics, 10 unstable metrics. scenario:iastaspects-ljust_aspect
scenario:iastaspects-stringio_noaspect
scenario:iastaspectsospath-ospathbasename_aspect
scenario:span-start
scenario:telemetryaddmetric-1-count-metric-1-times
|
ContextVar crash
5225b92 to
1987e8b
Compare
brettlangdon
left a comment
There was a problem hiding this comment.
small release note nit, but otherwise lgtm
Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
|
This change is marked for backport to 4.10, but it conflicts with that branch. The command used to test backporting was |
|
This change is marked for backport to 4.8, but it conflicts with that branch. The command used to test backporting was |
|
This change is marked for backport to 4.11, but it conflicts with that branch. The command used to test backporting was |
|
This change is marked for backport to 4.9, but it conflicts with that branch. The command used to test backporting was |
Description
This is an attempt to fix a customer-reported crash (Jira).
ContextVar-related crash: fix(internal): crash in ContextVar #17407This fix addresses the issue in a sort of makeshift way like the CPython upstream fix would. Since we can't bump reference counts directly from CPython, the PR adds a Rust helper which takes care of it. Not great, not terrible.
Note the bug only happens in versions prior to 3.12 (which made significant changes to the GC and doesn't trigger that HAMT crash anymore), so the fix is gated to them.
The crash signature is