Skip to content

fix(tracing): prevent quadratic query string obfuscation [backport 3.19] - #20880

Merged
florentinl merged 7 commits into
3.19from
florentin.labelle/backport-20857-to-3.19
Oct 9, 2026
Merged

florentinl merged 7 commits into
3.19from
florentin.labelle/backport-20857-to-3.19

Conversation

@florentinl

@florentinl florentinl commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Description

Backports #20857 to 3.19, with configuration imports and type comments adapted for this branch. Includes CI Action updates, lint cleanup, proxy exclusions, and the LiteLLM test fix needed to validate the backport. Updates one-pipeline to 1.6.0 for OCI image-size validation, retaining 3.19's publishing flow.

Testing

Python 3.8: 413 passed, 1 skipped. LiteLLM on Python 3.9: 151 passed, 10 skipped. Full Linux lint passed. GitLab dry runs passed for branch and release-tag configurations; the OCI size checker passed against the built image and rejected an intentionally smaller limit. All 74 wheel identifiers preserved.

Risks

Same JWT matching behavior and performance changes as #20857. The pipeline update adds a 500 MiB injection footprint gate; new mutable-tag rollout jobs remain disabled. Full CI validates wheel builds and the pipeline upgrade.

Additional Notes

Includes the security release note. IAST query-string synchronization changes do not apply to 3.19.

Backport #20857, adapting configuration imports and type comments for 3.19.
IAST query-string synchronization changes do not apply to this branch.

(cherry picked from commit a6d7360)
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

releasenotes/notes/fix-query-string-obfuscation-ca8726c83a8d9667.yaml   @DataDog/apm-python
.github/workflows/build_deploy.yml                                      @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/build_python_3.yml                                    @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/pytorch_gpu_tests.yml                                 @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/unit_tests.yml                                        @DataDog/python-guild @DataDog/apm-core-python
.gitlab-ci.yml                                                          @DataDog/python-guild @DataDog/apm-core-python
.gitlab/benchmarks/bp-runner.microbenchmarks.fail-on-breach.yml         @DataDog/python-guild @DataDog/apm-core-python
.gitlab/one-pipeline.locked.yml                                         @DataDog/python-guild @DataDog/apm-core-python
ddtrace/contrib/internal/ray/patch.py                                   @DataDog/ml-observability
ddtrace/contrib/internal/ray/utils.py                                   @DataDog/ml-observability
ddtrace/contrib/internal/trace_utils_base.py                            @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/internal/_encoding.pyx                                          @DataDog/apm-core-python
ddtrace/internal/dist_computing/utils.py                                @DataDog/apm-core-python
ddtrace/internal/utils/http.py                                          @DataDog/apm-core-python
ddtrace/settings/_config.py                                             @DataDog/apm-core-python
docs/configuration.rst                                                  @DataDog/python-guild
docs/spelling_wordlist.txt                                              @DataDog/python-guild
hatch.toml                                                              @DataDog/python-guild
releasenotes/notes/fix-serverless-service-representation-b1f81fe0553a7a45.yaml  @DataDog/apm-python
scripts/gen_gitlab_config.py                                            @DataDog/apm-core-python
tests/README.md                                                         @DataDog/python-guild @DataDog/apm-core-python
tests/appsec/appsec/api_security/test_api_security_manager.py           @DataDog/asm-python
tests/contrib/litellm/test_litellm.py                                   @DataDog/ml-observability
tests/contrib/suitespec.yml                                             @DataDog/apm-core-python @DataDog/apm-idm-python
tests/llmobs/suitespec.yml                                              @DataDog/ml-observability
tests/profiling_v2/test_code_provenance.py                              @DataDog/profiling-python
tests/tracer/test_http.py                                               @DataDog/apm-sdk-capabilities-python
tests/tracer/test_trace_utils.py                                        @DataDog/apm-sdk-capabilities-python
tests/utils.py                                                          @DataDog/python-guild
tests/contrib/litellm/cassettes/completion_cohere_chat.yaml             @DataDog/ml-observability
.github/workflows/encoders-profile.yml                                  @DataDog/python-guild @DataDog/apm-core-python

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog retried 2 tests - 1 passed on retry View in Datadog

🚧 29 tests that failed were ignored due to quarantine View in Datadog

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b0fc22d | Docs | View more details | Give us feedback!

Update composite Actions with SHA-pinned dependencies and keep the wheel matrix generator aligned. Remove unused Cython declarations, correct spelling errors, and run the configured script doctests from lint checks.
@pr-commenter

pr-commenter Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Performance SLOs

Comparing candidate florentin.labelle/backport-20857-to-3.19 (b0fc22d) with baseline 3.19 (8e480ab)

📈 Performance Regressions (2 suites)
📈 iastaspectsospath - 12/12

✅ ospathbasename_aspect

Time: ✅ 4.404µs (SLO: <10.000µs 📉 -56.0%) vs baseline: +3.9%


✅ ospathbasename_noaspect

Time: ✅ 1.112µs (SLO: <10.000µs 📉 -88.9%) vs baseline: +1.0%


✅ ospathjoin_aspect

Time: ✅ 6.351µs (SLO: <10.000µs 📉 -36.5%) vs baseline: +2.7%


✅ ospathjoin_noaspect

Time: ✅ 2.282µs (SLO: <10.000µs 📉 -77.2%) vs baseline: ~same


✅ ospathnormcase_aspect

Time: ✅ 3.888µs (SLO: <10.000µs 📉 -61.1%) vs baseline: 📈 +11.0%


✅ ospathnormcase_noaspect

Time: ✅ 0.618µs (SLO: <10.000µs 📉 -93.8%) vs baseline: +3.1%


✅ ospathsplit_aspect

Time: ✅ 4.833µs (SLO: <10.000µs 📉 -51.7%) vs baseline: ~same


✅ ospathsplit_noaspect

Time: ✅ 1.613µs (SLO: <10.000µs 📉 -83.9%) vs baseline: +0.8%


✅ ospathsplitdrive_aspect

Time: ✅ 3.839µs (SLO: <10.000µs 📉 -61.6%) vs baseline: +4.1%


✅ ospathsplitdrive_noaspect

Time: ✅ 0.726µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +0.4%


✅ ospathsplitext_aspect

Time: ✅ 4.858µs (SLO: <10.000µs 📉 -51.4%) vs baseline: +5.6%


✅ ospathsplitext_noaspect

Time: ✅ 1.425µs (SLO: <10.000µs 📉 -85.7%) vs baseline: -0.7%


📈 sethttpmeta - 16/16

✅ all-disabled

Time: ✅ 10.640µs (SLO: <20.000µs 📉 -46.8%) vs baseline: -0.6%


✅ all-enabled

Time: ✅ 40.610µs (SLO: <50.000µs 📉 -18.8%) vs baseline: -0.3%


✅ collectipvariant_exists

Time: ✅ 42.052µs (SLO: <50.000µs 📉 -15.9%) vs baseline: +1.8%


✅ no-collectipvariant

Time: ✅ 40.820µs (SLO: <50.000µs 📉 -18.4%) vs baseline: +0.4%


✅ no-useragentvariant

Time: ✅ 39.243µs (SLO: <50.000µs 📉 -21.5%) vs baseline: +0.4%


✅ obfuscation-no-query

Time: ✅ 41.330µs (SLO: <50.000µs 📉 -17.3%) vs baseline: +0.6%


✅ obfuscation-regular-case-explicit-query

Time: ✅ 79.202µs (SLO: <90.000µs 📉 -12.0%) vs baseline: +6.7%


✅ obfuscation-regular-case-implicit-query

Time: ✅ 80.231µs (SLO: <90.000µs 📉 -10.9%) vs baseline: +6.7%


✅ obfuscation-send-querystring-disabled

Time: ✅ 174.316µs (SLO: <190.000µs -8.3%) vs baseline: 📈 +18.7%


✅ obfuscation-worst-case-explicit-query

Time: ✅ 168.138µs (SLO: <190.000µs 📉 -11.5%) vs baseline: 📈 +18.7%


✅ obfuscation-worst-case-implicit-query

Time: ✅ 173.439µs (SLO: <190.000µs -8.7%) vs baseline: 📈 +17.8%


✅ useragentvariant_exists_1

Time: ✅ 40.038µs (SLO: <50.000µs 📉 -19.9%) vs baseline: -0.2%


✅ useragentvariant_exists_2

Time: ✅ 41.750µs (SLO: <50.000µs 📉 -16.5%) vs baseline: +1.5%


✅ useragentvariant_exists_3

Time: ✅ 40.859µs (SLO: <50.000µs 📉 -18.3%) vs baseline: +0.5%


✅ useragentvariant_not_exists_1

Time: ✅ 39.994µs (SLO: <50.000µs 📉 -20.0%) vs baseline: -0.3%


✅ useragentvariant_not_exists_2

Time: ✅ 40.195µs (SLO: <50.000µs 📉 -19.6%) vs baseline: +0.5%

🟡 Near SLO Breach (4 suites)
🟡 djangosimple - 15/15

✅ appsec

Time: ✅ 21.260ms (SLO: <22.300ms -4.7%) vs baseline: -0.1%


✅ exception-replay-enabled

Time: ✅ 1.327ms (SLO: <1.450ms -8.5%) vs baseline: -0.5%


✅ iast

Time: ✅ 21.254ms (SLO: <22.250ms -4.5%) vs baseline: +0.1%


✅ profiler

Time: ✅ 15.558ms (SLO: <16.550ms -6.0%) vs baseline: +0.2%


✅ resource-renaming

Time: ✅ 21.351ms (SLO: <21.750ms 🟡 -1.8%) vs baseline: ~same


✅ span-code-origin

Time: ✅ 26.284ms (SLO: <28.200ms -6.8%) vs baseline: +0.1%


✅ tracer

Time: ✅ 21.251ms (SLO: <21.750ms -2.3%) vs baseline: -0.2%


✅ tracer-and-profiler

Time: ✅ 23.398ms (SLO: <23.500ms 🟡 -0.4%) vs baseline: +0.1%


✅ tracer-dont-create-db-spans

Time: ✅ 19.931ms (SLO: <21.500ms -7.3%) vs baseline: -0.1%


✅ tracer-minimal

Time: ✅ 17.247ms (SLO: <17.500ms 🟡 -1.4%) vs baseline: ~same


✅ tracer-native

Time: ✅ 21.287ms (SLO: <21.750ms -2.1%) vs baseline: ~same


✅ tracer-no-caches

Time: ✅ 19.298ms (SLO: <19.650ms 🟡 -1.8%) vs baseline: ~same


✅ tracer-no-databases

Time: ✅ 19.355ms (SLO: <20.100ms -3.7%) vs baseline: ~same


✅ tracer-no-middleware

Time: ✅ 20.886ms (SLO: <21.500ms -2.9%) vs baseline: -0.8%


✅ tracer-no-templates

Time: ✅ 21.138ms (SLO: <22.000ms -3.9%) vs baseline: +0.1%


🟡 otelsdkspan - 12/12

✅ add-event

Time: ✅ 38.483ms (SLO: <42.000ms -8.4%) vs baseline: +0.4%


✅ add-link

Time: ✅ 34.403ms (SLO: <38.550ms 📉 -10.8%) vs baseline: -0.1%


✅ add-metrics

Time: ✅ 224.951ms (SLO: <232.000ms -3.0%) vs baseline: +0.6%


✅ add-tags

Time: ✅ 217.253ms (SLO: <221.600ms 🟡 -2.0%) vs baseline: +0.4%


✅ get-context

Time: ✅ 27.641ms (SLO: <31.300ms 📉 -11.7%) vs baseline: -0.5%


✅ is-recording

Time: ✅ 27.501ms (SLO: <31.000ms 📉 -11.3%) vs baseline: -1.0%


✅ record-exception

Time: ✅ 60.584ms (SLO: <65.850ms -8.0%) vs baseline: +0.3%


✅ set-status

Time: ✅ 30.288ms (SLO: <34.150ms 📉 -11.3%) vs baseline: -0.6%


✅ start

Time: ✅ 27.511ms (SLO: <30.150ms -8.8%) vs baseline: +0.4%


✅ start-finish

Time: ✅ 32.022ms (SLO: <35.350ms -9.4%) vs baseline: -0.4%


✅ start-finish-telemetry

Time: ✅ 31.762ms (SLO: <35.450ms 📉 -10.4%) vs baseline: -1.0%


✅ update-name

Time: ✅ 29.470ms (SLO: <33.400ms 📉 -11.8%) vs baseline: -0.4%


🟡 packagespackageforrootmodulemapping - 2/2

✅ cache_off

Time: ✅ 349.145ms (SLO: <354.300ms 🟡 -1.5%) vs baseline: +0.2%


✅ cache_on

Time: ✅ 0.386µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +0.5%


🟡 telemetryaddmetric - 15/15

✅ 1-count-metric-1-times

Time: ✅ 4.368µs (SLO: <20.000µs 📉 -78.2%) vs baseline: +4.1%


✅ 1-count-metrics-100-times

Time: ✅ 319.768µs (SLO: <350.000µs -8.6%) vs baseline: -1.4%


✅ 1-distribution-metric-1-times

Time: ✅ 4.607µs (SLO: <20.000µs 📉 -77.0%) vs baseline: +2.1%


✅ 1-distribution-metrics-100-times

Time: ✅ 345.219µs (SLO: <360.000µs -4.1%) vs baseline: +0.9%


✅ 1-gauge-metric-1-times

Time: ✅ 2.273µs (SLO: <20.000µs 📉 -88.6%) vs baseline: -2.0%


✅ 1-gauge-metrics-100-times

Time: ✅ 147.929µs (SLO: <150.000µs 🟡 -1.4%) vs baseline: -1.1%


✅ 1-rate-metric-1-times

Time: ✅ 4.449µs (SLO: <20.000µs 📉 -77.8%) vs baseline: +2.1%


✅ 1-rate-metrics-100-times

Time: ✅ 334.195µs (SLO: <360.000µs -7.2%) vs baseline: -0.4%


✅ 100-count-metrics-100-times

Time: ✅ 33.352ms (SLO: <33.860ms 🟡 -1.5%) vs baseline: +1.3%


✅ 100-distribution-metrics-100-times

Time: ✅ 3.470ms (SLO: <3.590ms -3.3%) vs baseline: +0.3%


✅ 100-gauge-metrics-100-times

Time: ✅ 1.538ms (SLO: <1.550ms 🟡 -0.8%) vs baseline: -1.0%


✅ 100-rate-metrics-100-times

Time: ✅ 3.513ms (SLO: <3.610ms -2.7%) vs baseline: +1.4%


✅ flush-1-metric

Time: ✅ 5.841µs (SLO: <20.000µs 📉 -70.8%) vs baseline: -0.5%


✅ flush-100-metrics

Time: ✅ 181.377µs (SLO: <250.000µs 📉 -27.4%) vs baseline: -3.0%


✅ flush-1000-metrics

Time: ✅ 2.228ms (SLO: <2.500ms 📉 -10.9%) vs baseline: -0.9%

⚠️ Unstable Tests (1 suite)
⚠️ coreapiscenario - 5/5 (1 unstable)

⚠️ context_with_data_listeners

Time: ⚠️ 13.581µs (SLO: <20.000µs 📉 -32.1%) vs baseline: -0.7%


✅ context_with_data_no_listeners

Time: ✅ 3.319µs (SLO: <10.000µs 📉 -66.8%) vs baseline: -0.7%


✅ get_item_exists

Time: ✅ 0.595µs (SLO: <10.000µs 📉 -94.1%) vs baseline: -0.3%


✅ get_item_missing

Time: ✅ 0.651µs (SLO: <10.000µs 📉 -93.5%) vs baseline: +0.1%


✅ set_item

Time: ✅ 25.026µs (SLO: <30.000µs 📉 -16.6%) vs baseline: +0.7%

✅ All Tests Passing (16 suites)
✅ errortrackingdjangosimple - 3/3

✅ errortracking-enabled-all

Time: ✅ 19.018ms (SLO: <19.850ms -4.2%) vs baseline: +0.4%


✅ errortracking-enabled-user

Time: ✅ 18.947ms (SLO: <19.400ms -2.3%) vs baseline: +0.4%


✅ tracer-enabled

Time: ✅ 18.893ms (SLO: <19.450ms -2.9%) vs baseline: ~same


✅ errortrackingflasksqli - 3/3

✅ errortracking-enabled-all

Time: ✅ 2.068ms (SLO: <2.300ms 📉 -10.1%) vs baseline: +0.3%


✅ errortracking-enabled-user

Time: ✅ 2.063ms (SLO: <2.250ms -8.3%) vs baseline: ~same


✅ tracer-enabled

Time: ✅ 2.068ms (SLO: <2.300ms 📉 -10.1%) vs baseline: +0.2%


✅ flasksimple - 9/9

✅ appsec-get

Time: ✅ 4.542ms (SLO: <4.750ms -4.4%) vs baseline: ~same


✅ appsec-post

Time: ✅ 6.585ms (SLO: <6.750ms -2.4%) vs baseline: +0.2%


✅ appsec-telemetry

Time: ✅ 4.539ms (SLO: <4.750ms -4.4%) vs baseline: +0.4%


✅ debugger

Time: ✅ 1.819ms (SLO: <2.000ms -9.0%) vs baseline: -0.3%


✅ iast-get

Time: ✅ 1.823ms (SLO: <2.000ms -8.9%) vs baseline: +0.1%


✅ profiler

Time: ✅ 1.883ms (SLO: <2.100ms 📉 -10.3%) vs baseline: ~same


✅ resource-renaming

Time: ✅ 3.324ms (SLO: <3.650ms -8.9%) vs baseline: ~same


✅ tracer

Time: ✅ 3.299ms (SLO: <3.650ms -9.6%) vs baseline: -0.2%


✅ tracer-native

Time: ✅ 3.308ms (SLO: <3.650ms -9.4%) vs baseline: ~same


✅ flasksqli - 3/3

✅ appsec-enabled

Time: ✅ 4.005ms (SLO: <4.200ms -4.6%) vs baseline: -0.3%


✅ iast-enabled

Time: ✅ 2.476ms (SLO: <2.800ms 📉 -11.6%) vs baseline: -0.6%


✅ tracer-enabled

Time: ✅ 2.091ms (SLO: <2.250ms -7.1%) vs baseline: ~same


✅ httppropagationextract - 30/30

✅ all_styles_all_headers

Time: ✅ 87.140µs (SLO: <100.000µs 📉 -12.9%) vs baseline: +0.5%


✅ b3_headers

Time: ✅ 15.789µs (SLO: <20.000µs 📉 -21.1%) vs baseline: +0.4%


✅ b3_single_headers

Time: ✅ 14.929µs (SLO: <20.000µs 📉 -25.4%) vs baseline: +0.8%


✅ datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match

Time: ✅ 67.772µs (SLO: <80.000µs 📉 -15.3%) vs baseline: +0.5%


✅ datadog_tracecontext_tracestate_propagated_on_trace_id_match

Time: ✅ 68.686µs (SLO: <80.000µs 📉 -14.1%) vs baseline: ~same


✅ empty_headers

Time: ✅ 1.607µs (SLO: <10.000µs 📉 -83.9%) vs baseline: +0.3%


✅ full_t_id_datadog_headers

Time: ✅ 24.517µs (SLO: <30.000µs 📉 -18.3%) vs baseline: -0.1%


✅ invalid_priority_header

Time: ✅ 6.624µs (SLO: <10.000µs 📉 -33.8%) vs baseline: -0.1%


✅ invalid_span_id_header

Time: ✅ 6.620µs (SLO: <10.000µs 📉 -33.8%) vs baseline: -0.7%


✅ invalid_tags_header

Time: ✅ 6.570µs (SLO: <10.000µs 📉 -34.3%) vs baseline: -0.7%


✅ invalid_trace_id_header

Time: ✅ 6.614µs (SLO: <10.000µs 📉 -33.9%) vs baseline: ~same


✅ large_header_no_matches

Time: ✅ 27.107µs (SLO: <30.000µs -9.6%) vs baseline: -0.5%


✅ large_valid_headers_all

Time: ✅ 28.383µs (SLO: <40.000µs 📉 -29.0%) vs baseline: +0.4%


✅ medium_header_no_matches

Time: ✅ 9.777µs (SLO: <20.000µs 📉 -51.1%) vs baseline: -0.2%


✅ medium_valid_headers_all

Time: ✅ 11.179µs (SLO: <20.000µs 📉 -44.1%) vs baseline: +0.1%


✅ none_propagation_style

Time: ✅ 1.717µs (SLO: <10.000µs 📉 -82.8%) vs baseline: +0.2%


✅ tracecontext_headers

Time: ✅ 36.416µs (SLO: <40.000µs -9.0%) vs baseline: ~same


✅ valid_headers_all

Time: ✅ 6.565µs (SLO: <10.000µs 📉 -34.3%) vs baseline: -1.6%


✅ valid_headers_basic

Time: ✅ 6.203µs (SLO: <10.000µs 📉 -38.0%) vs baseline: -0.5%


✅ wsgi_empty_headers

Time: ✅ 1.598µs (SLO: <10.000µs 📉 -84.0%) vs baseline: -1.0%


✅ wsgi_invalid_priority_header

Time: ✅ 6.646µs (SLO: <10.000µs 📉 -33.5%) vs baseline: -0.5%


✅ wsgi_invalid_span_id_header

Time: ✅ 1.595µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.2%


✅ wsgi_invalid_tags_header

Time: ✅ 6.685µs (SLO: <10.000µs 📉 -33.2%) vs baseline: ~same


✅ wsgi_invalid_trace_id_header

Time: ✅ 6.680µs (SLO: <10.000µs 📉 -33.2%) vs baseline: -0.2%


✅ wsgi_large_header_no_matches

Time: ✅ 27.674µs (SLO: <40.000µs 📉 -30.8%) vs baseline: -0.5%


✅ wsgi_large_valid_headers_all

Time: ✅ 28.971µs (SLO: <40.000µs 📉 -27.6%) vs baseline: +0.4%


✅ wsgi_medium_header_no_matches

Time: ✅ 9.984µs (SLO: <20.000µs 📉 -50.1%) vs baseline: +0.2%


✅ wsgi_medium_valid_headers_all

Time: ✅ 11.525µs (SLO: <20.000µs 📉 -42.4%) vs baseline: +1.1%


✅ wsgi_valid_headers_all

Time: ✅ 6.658µs (SLO: <10.000µs 📉 -33.4%) vs baseline: -0.7%


✅ wsgi_valid_headers_basic

Time: ✅ 6.233µs (SLO: <10.000µs 📉 -37.7%) vs baseline: -0.6%


✅ httppropagationinject - 8/8

✅ ids_only

Time: ✅ 23.632µs (SLO: <30.000µs 📉 -21.2%) vs baseline: +1.3%


✅ with_all

Time: ✅ 30.345µs (SLO: <40.000µs 📉 -24.1%) vs baseline: +0.5%


✅ with_dd_origin

Time: ✅ 27.394µs (SLO: <30.000µs -8.7%) vs baseline: +1.5%


✅ with_priority_and_origin

Time: ✅ 26.378µs (SLO: <40.000µs 📉 -34.1%) vs baseline: +0.3%


✅ with_sampling_priority

Time: ✅ 23.315µs (SLO: <30.000µs 📉 -22.3%) vs baseline: -0.3%


✅ with_tags

Time: ✅ 28.919µs (SLO: <40.000µs 📉 -27.7%) vs baseline: +1.9%


✅ with_tags_invalid

Time: ✅ 29.811µs (SLO: <40.000µs 📉 -25.5%) vs baseline: -0.4%


✅ with_tags_max_size

Time: ✅ 28.891µs (SLO: <40.000µs 📉 -27.8%) vs baseline: ~same


✅ iast_aspects - 20/20

✅ re_expand_aspect

Time: ✅ 32.930µs (SLO: <40.000µs 📉 -17.7%) vs baseline: +0.6%


✅ re_expand_noaspect

Time: ✅ 29.590µs (SLO: <40.000µs 📉 -26.0%) vs baseline: +0.5%


✅ re_findall_aspect

Time: ✅ 2.940µs (SLO: <10.000µs 📉 -70.6%) vs baseline: +0.4%


✅ re_findall_noaspect

Time: ✅ 1.409µs (SLO: <10.000µs 📉 -85.9%) vs baseline: -0.4%


✅ re_finditer_aspect

Time: ✅ 4.494µs (SLO: <10.000µs 📉 -55.1%) vs baseline: ~same


✅ re_finditer_noaspect

Time: ✅ 1.444µs (SLO: <10.000µs 📉 -85.6%) vs baseline: +0.7%


✅ re_fullmatch_aspect

Time: ✅ 2.777µs (SLO: <10.000µs 📉 -72.2%) vs baseline: -0.8%


✅ re_fullmatch_noaspect

Time: ✅ 1.302µs (SLO: <10.000µs 📉 -87.0%) vs baseline: -1.7%


✅ re_group_aspect

Time: ✅ 3.005µs (SLO: <10.000µs 📉 -69.9%) vs baseline: -3.6%


✅ re_group_noaspect

Time: ✅ 1.643µs (SLO: <10.000µs 📉 -83.6%) vs baseline: +0.5%


✅ re_groups_aspect

Time: ✅ 3.172µs (SLO: <10.000µs 📉 -68.3%) vs baseline: -0.1%


✅ re_groups_noaspect

Time: ✅ 1.748µs (SLO: <10.000µs 📉 -82.5%) vs baseline: +2.0%


✅ re_match_aspect

Time: ✅ 2.792µs (SLO: <10.000µs 📉 -72.1%) vs baseline: -3.5%


✅ re_match_noaspect

Time: ✅ 1.341µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +2.3%


✅ re_search_aspect

Time: ✅ 2.625µs (SLO: <10.000µs 📉 -73.7%) vs baseline: -1.8%


✅ re_search_noaspect

Time: ✅ 1.212µs (SLO: <10.000µs 📉 -87.9%) vs baseline: ~same


✅ re_sub_aspect

Time: ✅ 3.532µs (SLO: <10.000µs 📉 -64.7%) vs baseline: -0.6%


✅ re_sub_noaspect

Time: ✅ 1.586µs (SLO: <10.000µs 📉 -84.1%) vs baseline: ~same


✅ re_subn_aspect

Time: ✅ 3.664µs (SLO: <10.000µs 📉 -63.4%) vs baseline: -2.2%


✅ re_subn_noaspect

Time: ✅ 1.654µs (SLO: <10.000µs 📉 -83.5%) vs baseline: ~same


✅ iastaspects - 59/59

✅ add_aspect

Time: ✅ 0.389µs (SLO: <10.000µs 📉 -96.1%) vs baseline: -0.9%


✅ add_inplace_aspect

Time: ✅ 0.392µs (SLO: <10.000µs 📉 -96.1%) vs baseline: -0.3%


✅ add_inplace_noaspect

Time: ✅ 0.288µs (SLO: <10.000µs 📉 -97.1%) vs baseline: +0.7%


✅ add_noaspect

Time: ✅ 0.360µs (SLO: <10.000µs 📉 -96.4%) vs baseline: -0.6%


✅ bytearray_aspect

Time: ✅ 1.279µs (SLO: <10.000µs 📉 -87.2%) vs baseline: -1.4%


✅ bytearray_extend_aspect

Time: ✅ 1.520µs (SLO: <10.000µs 📉 -84.8%) vs baseline: -0.6%


✅ bytearray_extend_noaspect

Time: ✅ 0.644µs (SLO: <10.000µs 📉 -93.6%) vs baseline: ~same


✅ bytearray_noaspect

Time: ✅ 0.482µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -0.2%


✅ bytes_aspect

Time: ✅ 1.254µs (SLO: <10.000µs 📉 -87.5%) vs baseline: -0.8%


✅ bytes_noaspect

Time: ✅ 0.483µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -0.4%


✅ bytesio_aspect

Time: ✅ 1.282µs (SLO: <10.000µs 📉 -87.2%) vs baseline: -3.2%


✅ bytesio_noaspect

Time: ✅ 0.501µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.8%


✅ capitalize_aspect

Time: ✅ 0.737µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -0.8%


✅ capitalize_noaspect

Time: ✅ 0.435µs (SLO: <10.000µs 📉 -95.6%) vs baseline: +0.7%


✅ casefold_aspect

Time: ✅ 0.744µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +1.0%


✅ casefold_noaspect

Time: ✅ 0.367µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +1.3%


✅ decode_aspect

Time: ✅ 0.739µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +1.0%


✅ decode_noaspect

Time: ✅ 0.415µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.3%


✅ encode_aspect

Time: ✅ 0.713µs (SLO: <10.000µs 📉 -92.9%) vs baseline: ~same


✅ encode_noaspect

Time: ✅ 0.397µs (SLO: <10.000µs 📉 -96.0%) vs baseline: ~same


✅ format_aspect

Time: ✅ 3.425µs (SLO: <10.000µs 📉 -65.8%) vs baseline: -1.2%


✅ format_map_aspect

Time: ✅ 3.589µs (SLO: <10.000µs 📉 -64.1%) vs baseline: +0.9%


✅ format_map_noaspect

Time: ✅ 0.831µs (SLO: <10.000µs 📉 -91.7%) vs baseline: -0.5%


✅ format_noaspect

Time: ✅ 0.603µs (SLO: <10.000µs 📉 -94.0%) vs baseline: -0.6%


✅ index_aspect

Time: ✅ 0.345µs (SLO: <10.000µs 📉 -96.6%) vs baseline: +0.6%


✅ index_noaspect

Time: ✅ 0.314µs (SLO: <10.000µs 📉 -96.9%) vs baseline: -0.4%


✅ join_aspect

Time: ✅ 1.276µs (SLO: <10.000µs 📉 -87.2%) vs baseline: -4.3%


✅ join_noaspect

Time: ✅ 0.536µs (SLO: <10.000µs 📉 -94.6%) vs baseline: -0.6%


✅ ljust_aspect

Time: ✅ 2.552µs (SLO: <20.000µs 📉 -87.2%) vs baseline: -2.0%


✅ ljust_noaspect

Time: ✅ 0.405µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.4%


✅ lower_aspect

Time: ✅ 2.194µs (SLO: <10.000µs 📉 -78.1%) vs baseline: -2.2%


✅ lower_noaspect

Time: ✅ 0.369µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +2.0%


✅ lstrip_aspect

Time: ✅ 2.236µs (SLO: <20.000µs 📉 -88.8%) vs baseline: +0.3%


✅ lstrip_noaspect

Time: ✅ 0.380µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.5%


✅ modulo_aspect

Time: ✅ 0.986µs (SLO: <10.000µs 📉 -90.1%) vs baseline: +0.2%


✅ modulo_aspect_for_bytearray_bytearray

Time: ✅ 1.465µs (SLO: <10.000µs 📉 -85.3%) vs baseline: +1.4%


✅ modulo_aspect_for_bytes

Time: ✅ 0.948µs (SLO: <10.000µs 📉 -90.5%) vs baseline: -0.1%


✅ modulo_aspect_for_bytes_bytearray

Time: ✅ 1.174µs (SLO: <10.000µs 📉 -88.3%) vs baseline: +0.9%


✅ modulo_noaspect

Time: ✅ 0.671µs (SLO: <10.000µs 📉 -93.3%) vs baseline: ~same


✅ replace_aspect

Time: ✅ 4.874µs (SLO: <10.000µs 📉 -51.3%) vs baseline: +0.5%


✅ replace_noaspect

Time: ✅ 0.464µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.1%


✅ repr_aspect

Time: ✅ 0.949µs (SLO: <10.000µs 📉 -90.5%) vs baseline: ~same


✅ repr_noaspect

Time: ✅ 0.445µs (SLO: <10.000µs 📉 -95.5%) vs baseline: -0.7%


✅ rstrip_aspect

Time: ✅ 1.933µs (SLO: <20.000µs 📉 -90.3%) vs baseline: -1.7%


✅ rstrip_noaspect

Time: ✅ 0.378µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.8%


✅ slice_aspect

Time: ✅ 0.475µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -1.3%


✅ slice_noaspect

Time: ✅ 0.444µs (SLO: <10.000µs 📉 -95.6%) vs baseline: +0.9%


✅ stringio_aspect

Time: ✅ 1.724µs (SLO: <10.000µs 📉 -82.8%) vs baseline: +2.3%


✅ stringio_noaspect

Time: ✅ 0.893µs (SLO: <10.000µs 📉 -91.1%) vs baseline: ~same


✅ strip_aspect

Time: ✅ 2.229µs (SLO: <20.000µs 📉 -88.9%) vs baseline: +0.8%


✅ strip_noaspect

Time: ✅ 0.381µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.0%


✅ swapcase_aspect

Time: ✅ 2.409µs (SLO: <10.000µs 📉 -75.9%) vs baseline: -0.8%


✅ swapcase_noaspect

Time: ✅ 0.532µs (SLO: <10.000µs 📉 -94.7%) vs baseline: +1.2%


✅ title_aspect

Time: ✅ 2.484µs (SLO: <10.000µs 📉 -75.2%) vs baseline: +3.4%


✅ title_noaspect

Time: ✅ 0.498µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.9%


✅ translate_aspect

Time: ✅ 3.137µs (SLO: <10.000µs 📉 -68.6%) vs baseline: -1.9%


✅ translate_noaspect

Time: ✅ 1.045µs (SLO: <10.000µs 📉 -89.5%) vs baseline: +0.4%


✅ upper_aspect

Time: ✅ 2.179µs (SLO: <10.000µs 📉 -78.2%) vs baseline: -3.4%


✅ upper_noaspect

Time: ✅ 0.371µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.5%


✅ iastaspectssplit - 6/6

✅ rsplit_aspect

Time: ✅ 1.365µs (SLO: <10.000µs 📉 -86.4%) vs baseline: -6.2%


✅ rsplit_noaspect

Time: ✅ 0.586µs (SLO: <10.000µs 📉 -94.1%) vs baseline: -0.4%


✅ split_aspect

Time: ✅ 1.380µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -9.3%


✅ split_noaspect

Time: ✅ 0.584µs (SLO: <10.000µs 📉 -94.2%) vs baseline: -0.3%


✅ splitlines_aspect

Time: ✅ 1.442µs (SLO: <10.000µs 📉 -85.6%) vs baseline: -3.2%


✅ splitlines_noaspect

Time: ✅ 0.595µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.6%


✅ otelspan - 11/11

✅ add-event

Time: ✅ 39.060ms (SLO: <47.150ms 📉 -17.2%) vs baseline: +1.0%


✅ add-metrics

Time: ✅ 324.517ms (SLO: <344.800ms -5.9%) vs baseline: +1.3%


✅ add-tags

Time: ✅ 290.695ms (SLO: <314.000ms -7.4%) vs baseline: -1.2%


✅ get-context

Time: ✅ 80.305ms (SLO: <92.350ms 📉 -13.0%) vs baseline: +2.1%


✅ is-recording

Time: ✅ 36.446ms (SLO: <44.500ms 📉 -18.1%) vs baseline: +0.6%


✅ record-exception

Time: ✅ 57.853ms (SLO: <67.650ms 📉 -14.5%) vs baseline: +1.9%


✅ set-status

Time: ✅ 42.301ms (SLO: <50.400ms 📉 -16.1%) vs baseline: +0.7%


✅ start

Time: ✅ 35.695ms (SLO: <43.450ms 📉 -17.8%) vs baseline: +0.8%


✅ start-finish

Time: ✅ 81.958ms (SLO: <88.000ms -6.9%) vs baseline: -0.4%


✅ start-finish-telemetry

Time: ✅ 83.875ms (SLO: <89.000ms -5.8%) vs baseline: -0.2%


✅ update-name

Time: ✅ 37.525ms (SLO: <45.150ms 📉 -16.9%) vs baseline: +1.0%


✅ packagesupdateimporteddependencies - 12/12

✅ import_many

Time: ✅ 149.460µs (SLO: <170.000µs 📉 -12.1%) vs baseline: +0.5%


✅ import_many_cached

Time: ✅ 116.513µs (SLO: <130.000µs 📉 -10.4%) vs baseline: +0.7%


✅ import_many_stdlib

Time: ✅ 1.595ms (SLO: <1.750ms -8.9%) vs baseline: ~same


✅ import_many_stdlib_cached

Time: ✅ 0.958ms (SLO: <1.100ms 📉 -12.9%) vs baseline: +0.7%


✅ import_many_unknown

Time: ✅ 808.386µs (SLO: <890.000µs -9.2%) vs baseline: -0.2%


✅ import_many_unknown_cached

Time: ✅ 765.385µs (SLO: <870.000µs 📉 -12.0%) vs baseline: -0.4%


✅ import_one

Time: ✅ 19.720µs (SLO: <30.000µs 📉 -34.3%) vs baseline: +0.2%


✅ import_one_cache

Time: ✅ 6.060µs (SLO: <10.000µs 📉 -39.4%) vs baseline: -0.3%


✅ import_one_stdlib

Time: ✅ 18.599µs (SLO: <20.000µs -7.0%) vs baseline: ~same


✅ import_one_stdlib_cache

Time: ✅ 6.093µs (SLO: <10.000µs 📉 -39.1%) vs baseline: +0.3%


✅ import_one_unknown

Time: ✅ 44.742µs (SLO: <50.000µs 📉 -10.5%) vs baseline: ~same


✅ import_one_unknown_cache

Time: ✅ 6.068µs (SLO: <10.000µs 📉 -39.3%) vs baseline: -0.7%


✅ ratelimiter - 6/6

✅ defaults

Time: ✅ 2.423µs (SLO: <10.000µs 📉 -75.8%) vs baseline: +0.7%


✅ high_rate_limit

Time: ✅ 2.468µs (SLO: <10.000µs 📉 -75.3%) vs baseline: -0.3%


✅ long_window

Time: ✅ 2.412µs (SLO: <10.000µs 📉 -75.9%) vs baseline: -0.7%


✅ low_rate_limit

Time: ✅ 2.412µs (SLO: <10.000µs 📉 -75.9%) vs baseline: ~same


✅ no_rate_limit

Time: ✅ 0.873µs (SLO: <10.000µs 📉 -91.3%) vs baseline: ~same


✅ short_window

Time: ✅ 2.539µs (SLO: <10.000µs 📉 -74.6%) vs baseline: +0.2%


✅ recursivecomputation - 4/4

✅ deep

Time: ✅ 293.505ms (SLO: <320.950ms -8.6%) vs baseline: +0.2%


✅ deep-profiled

Time: ✅ 313.091ms (SLO: <359.150ms 📉 -12.8%) vs baseline: +0.1%


✅ medium

Time: ✅ 6.700ms (SLO: <7.400ms -9.5%) vs baseline: +0.3%


✅ shallow

Time: ✅ 0.912ms (SLO: <1.050ms 📉 -13.1%) vs baseline: +0.5%


✅ samplingrules - 4/4

✅ average_match

Time: ✅ 140.462µs (SLO: <290.000µs 📉 -51.6%) vs baseline: -0.7%


✅ high_match

Time: ✅ 179.905µs (SLO: <480.000µs 📉 -62.5%) vs baseline: +1.7%


✅ low_match

Time: ✅ 102.703µs (SLO: <120.000µs 📉 -14.4%) vs baseline: -0.3%


✅ very_low_match

Time: ✅ 2.702ms (SLO: <8.500ms 📉 -68.2%) vs baseline: -0.3%


✅ span - 13/13

✅ add-event

Time: ✅ 17.665ms (SLO: <22.500ms 📉 -21.5%) vs baseline: +0.1%


✅ add-metrics

Time: ✅ 88.159ms (SLO: <93.500ms -5.7%) vs baseline: -1.4%


✅ add-tags

Time: ✅ 147.222ms (SLO: <155.000ms -5.0%) vs baseline: +0.4%


✅ get-context

Time: ✅ 15.947ms (SLO: <20.500ms 📉 -22.2%) vs baseline: ~same


✅ is-recording

Time: ✅ 16.332ms (SLO: <20.500ms 📉 -20.3%) vs baseline: +0.9%


✅ record-exception

Time: ✅ 34.813ms (SLO: <40.000ms 📉 -13.0%) vs baseline: +0.7%


✅ set-status

Time: ✅ 18.077ms (SLO: <22.000ms 📉 -17.8%) vs baseline: +1.2%


✅ start

Time: ✅ 15.849ms (SLO: <20.500ms 📉 -22.7%) vs baseline: +0.2%


✅ start-finish

Time: ✅ 50.794ms (SLO: <52.500ms -3.3%) vs baseline: +0.1%


✅ start-finish-telemetry

Time: ✅ 52.533ms (SLO: <54.500ms -3.6%) vs baseline: +0.5%


✅ start-finish-traceid128

Time: ✅ 54.036ms (SLO: <57.000ms -5.2%) vs baseline: ~same


✅ start-traceid128

Time: ✅ 16.183ms (SLO: <22.500ms 📉 -28.1%) vs baseline: +0.2%


✅ update-name

Time: ✅ 16.354ms (SLO: <22.000ms 📉 -25.7%) vs baseline: +0.5%


✅ tracer - 3/3

✅ large

Time: ✅ 28.416ms (SLO: <32.950ms 📉 -13.8%) vs baseline: +0.7%


✅ medium

Time: ✅ 2.823ms (SLO: <3.200ms 📉 -11.8%) vs baseline: +0.9%


✅ small

Time: ✅ 312.451µs (SLO: <370.000µs 📉 -15.6%) vs baseline: -0.7%

ℹ️ Scenarios Missing SLO Configuration (9 scenarios)

The following scenarios exist in candidate data but have no SLO thresholds configured:

  • coreapiscenario-core_dispatch_listeners
  • coreapiscenario-core_dispatch_no_listeners
  • coreapiscenario-core_dispatch_with_results_listeners
  • coreapiscenario-core_dispatch_with_results_no_listeners
  • djangosimple-baseline
  • errortrackingdjangosimple-baseline
  • errortrackingflasksqli-baseline
  • flasksimple-baseline
  • flasksqli-baseline

@florentinl
florentinl marked this pull request as ready for review October 9, 2026 09:09
@florentinl
florentinl requested review from a team as code owners October 9, 2026 09:09
@florentinl
florentinl requested review from avara1986, emmettbutler, gyuheon0h, quinna-h and rachelyangdog and removed request for a team October 9, 2026 09:09
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T09:13:17.022886Z b0fc22d Draft marked ready
🔒 Security Review ✅ Completed 2026-10-09T09:15:52.412667Z b0fc22d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: FAIL

The new CI proxy setup discards lowercase-only exclusions when NO_PROXY and no_proxy differ. With a proxy configured, this sends local integration-test traffic through the proxy instead of the test server.

Open Bits AI session

🤖 Bits Code Review · Commit b0fc22d · @DataDog review to ask questions

Comment thread scripts/gen_gitlab_config.py
@florentinl
florentinl merged commit 63ddc3c into 3.19 Oct 9, 2026
909 of 910 checks passed
@florentinl
florentinl deleted the florentin.labelle/backport-20857-to-3.19 branch October 9, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants