Repository navigation
Conversation
Require dependent UFC references to ignore new fields while preserving assignments and telemetry. Environment: Datadog workspace Co-Authored-By: Codex GPT-6 <noreply@localhost>
State explicitly that flagEvaluation.property is deliberately unknown and must be ignored. Environment: Datadog workspace Co-Authored-By: Codex GPT-6 <noreply@localhost>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the added regression coverage of unknown fields in dependent-flag references.
No open issues 🎉
What changed in this PR
Adds regression coverage to the separately activated dependent-flags suite to verify that unknown fields in flagEvaluation references do not invalidate dependent flags.
Changes:
- Adds a dependent root with an unknown reference field, plus unknown condition and evaluator fields.
- Expects the existing
direct-matchresult and exactly one exposure and evaluation event for both the prerequisite and root flags.
| File | Description |
|---|---|
evaluation-suites/dependent-flags/ufc-config.json |
Adds unknown fields and a dependent root flag to exercise parser tolerance. |
evaluation-suites/dependent-flags/cases/dependent-flags.json |
Adds assignment and exact telemetry expectations for the new root. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adding an unknown field inside
flagEvaluationmust not invalidate a dependent flag. Existing shared dependency cases contain key-only references, so they do not catch parsers that reject future reference fields.Changes
{"key": "dependent-leaf-on", "property": "variant"}and unknown condition/evaluator fields.direct-matchassignment as the existing direct dependency case, with exactly one parent/root exposure and evaluation event each.Decisions
This extends the existing unknown-UFC-field tolerance contract and is separate from DataDog/libdatadog#2748. The branch starts from the fixture revision used for the Rust review so the downstream snapshot update stays scoped. SDK activation remains managed by the existing system-tests activation PRs.
Validation
Checklist