Repository navigation
Prepare lading 0.34.0 release - #1943
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3bfce2fca
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
d3bfce2 to
45e2e65
Compare
| Only an all-zero set is rejected. | ||
| - **Breaking Change**: Capture Parquet files now declare `capture.version = "2.0"` and use `Dictionary(Int32, Utf8)` for label keys and values instead of `Utf8`. Arrow consumers must read these columns as dictionary arrays. | ||
| - **Breaking Change**: `captool` reads one capture schema major version. Select it with `--schema-major-version`. The default is the current major, `2`. `captool` rejects files that declare a different major. Use `--schema-major-version 1` for `1.x` captures and for captures without `capture.version`. `validate_parquet` takes the major as its `schema_major_version` argument. | ||
| - **Breaking Change**: TCP RR `flows` moved from the `tcp_rr` generator to the |
There was a problem hiding this comment.
this was the breaking change that was missing (from the automated review comment)
Motivation
There's a new capture data format in lading. This cuts a new release of lading to
0.34.0to make it available for downstream consumers.A new minor was cut since there's breaking changes (we don't use majors yet).
How this change fixes the issue
The PR sets the
ladingversion to0.34.0inlading/Cargo.tomlandCargo.lock.After this PR merges, a push of the
v0.34.0tag startsrelease.yml, which makes the GitHub release from the[0.34.0]section.