Repository navigation
fix(cicd): adopt Delivery Performance rename from Rust client - #918
Merged
Merged
Conversation
datadog-api-client-rust renamed the DORA Metrics API section to Delivery Performance (DataDog/datadog-api-client-rust@511bdbd106). Any pin after that commit fails to build cicd.rs, which blocks every client bump, including generated PRs. - Bump the client pin to 008f178b (0.38.0) - Use api_delivery_performance::DeliveryPerformanceAPI in cicd.rs - Drop the stale "0.33.0 tag" note from the pin comment Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MintsInc
marked this pull request as ready for review
October 15, 2026 08:46
Contributor
There was a problem hiding this comment.
More details
The client pin and lockfile agree, and the API import and constructor consistently adopt DeliveryPerformanceAPI while preserving the DORA CLI commands. The completed static reviewer reported no actionable regression.
🤖 Bits Code Review · Commit 801e32b
walidcavelius
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
datadog-api-client-rustrenamed the DORA Metrics API section to Delivery Performance in DataDog/datadog-api-client-rust@511bdbd106 (#2202):datadogV2::api_dora_metrics::DORAMetricsAPIbecamedatadogV2::api_delivery_performance::DeliveryPerformanceAPI. Any client pin after that commit fails to compilesrc/commands/cicd.rswithE0432: could not find api_dora_metrics in datadogV2. This currently breaks #908 (CI run), and it will break every later client bump the same way untilmainis fixed.Changes
008f178b(0.38.0), the same rev opt downtime list into pup generation #908 uses.patch_dora_deployment, ...) and models (DORADeploymentPatchRequest, ...) are unchanged, so the unstable-operations table andmake_api!need no changes.cicd doracommand names are left as-is. Renaming the CLI surface is a separate decision.datadog-api-cliententry, matching opt downtime list into pup generation #908.Tests
cargo checkreproduces the CI error. With the rename applied,cargo check --locked,cargo clippy --locked -- -D warnings, andcargo fmt --checkpass.cargo test --locked: 2200 passed, 6 failed. The failures are flaky under parallel load: they pass on their own, and the same set fails on unmodifiedmain.