Skip to content

fix(cicd): adopt Delivery Performance rename from Rust client - #918

Merged
MintsInc merged 1 commit into
mainfrom
ulysse.mavrocordatos/delivery-performance-rename
Oct 15, 2026
Merged

MintsInc merged 1 commit into
mainfrom
ulysse.mavrocordatos/delivery-performance-rename

Conversation

@MintsInc

Copy link
Copy Markdown
Member

Context

datadog-api-client-rust renamed the DORA Metrics API section to Delivery Performance in DataDog/datadog-api-client-rust@511bdbd106 (#2202): datadogV2::api_dora_metrics::DORAMetricsAPI became datadogV2::api_delivery_performance::DeliveryPerformanceAPI. Any client pin after that commit fails to compile src/commands/cicd.rs with E0432: could not find api_dora_metrics in datadogV2. This currently breaks #908 (CI run), and it will break every later client bump the same way until main is fixed.

Changes

  • The pin bump and the rename have to land together: the new module doesn't exist at the current pin, and the old one is gone after it. The pin moves to 008f178b (0.38.0), the same rev opt downtime list into pup generation #908 uses.
  • Only the module path and type name changed upstream. Method names (patch_dora_deployment, ...) and models (DORADeploymentPatchRequest, ...) are unchanged, so the unstable-operations table and make_api! need no changes.
  • The user-facing "DORA" wording and the cicd dora command names are left as-is. Renaming the CLI surface is a separate decision.
  • The lockfile diff only touches the datadog-api-client entry, matching opt downtime list into pup generation #908.

Tests

  • With only the pin bumped, cargo check reproduces the CI error. With the rename applied, cargo check --locked, cargo clippy --locked -- -D warnings, and cargo fmt --check pass.
  • cargo test --locked: 2200 passed, 6 failed. The failures are flaky under parallel load: they pass on their own, and the same set fails on unmodified main.
  • Cross-compile and WASM builds are left to this PR's CI.
  • Planned after merge: rebase or regenerate opt downtime list into pup generation #908 and confirm its CI goes green.

datadog-api-client-rust renamed the DORA Metrics API section to
Delivery Performance (DataDog/datadog-api-client-rust@511bdbd106).
Any pin after that commit fails to build cicd.rs, which blocks every
client bump, including generated PRs.

- Bump the client pin to 008f178b (0.38.0)
- Use api_delivery_performance::DeliveryPerformanceAPI in cicd.rs
- Drop the stale "0.33.0 tag" note from the pin comment

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MintsInc
MintsInc marked this pull request as ready for review October 15, 2026 08:46
@MintsInc
MintsInc requested a review from a team as a code owner October 15, 2026 08:46

@datadog-prod-us1-4 datadog-prod-us1-4 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The client pin and lockfile agree, and the API import and constructor consistently adopt DeliveryPerformanceAPI while preserving the DORA CLI commands. The completed static reviewer reported no actionable regression.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 801e32b

@MintsInc
MintsInc merged commit 54002d1 into main Oct 15, 2026
11 checks passed
@MintsInc
MintsInc deleted the ulysse.mavrocordatos/delivery-performance-rename branch October 15, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants