Repository navigation
fix(deps): bump async-trait to 0.1.92 for clippy 1.99 - #179
Merged
Merged
Conversation
Rust 1.99.0 reached the GitHub runner images, and its clippy flags double_must_use in code that async-trait 0.1.89 generates. Clippy runs with -D warnings, so datadog-trace-agent fails to compile. async-trait 0.1.92 fixes the generated code (dtolnay/async-trait#303). cargo also moves rustls from 0.23.45 to 0.23.44, because the manifests cap rustls below 0.23.45. CI's unlocked clippy run makes the same change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lym953
marked this pull request as ready for review
October 7, 2026 20:14
lym953
requested review from
Lewis-E and
duncanista
and
a balanced review from Copilot
and removed request for
a team and
Copilot
October 7, 2026 20:14
Lewis-E
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bumps
async-traitfrom 0.1.89 to 0.1.92 inCargo.lock.Motivation
What changed: the GitHub runner image
ubuntu-24.04-armmoved from version 20260927.135 to 20261004.142, which updates Rust from 1.98.1 to 1.99.0. The Clippy job uses the Rust of the runner image. Thewindows-2022job fails with the same 9 errors, but I did not check the Rust version of its image.The problem: Clippy 1.99 has the lint
double_must_use. It flags the code thatasync-trait0.1.89 generates for each#[async_trait]trait. The job runscargo clippy --workspace --all-features -- -D warnings, sodatadog-trace-agentfails to compile with 9 errors. The Clippy jobs onubuntu-24.04-armandwindows-2022fail on every PR, for example #178.mainwill fail the same way on its next run.The fix:
async-trait0.1.92 changes the generated code so that the lint does not apply (dtolnay/async-trait#303).Additional Notes
async-trait0.1.92 usessyn3, soCargo.lockaddssyn3.0.6. Thesyn2 entry stays for the other crates.cargo updatealso movesrustlsfrom 0.23.45 to 0.23.44. The manifests caprustlsbelow 0.23.45, but the lock file onmainhas 0.23.45. CI's Clippy run does not use--locked, so it already makes this same change before it builds.Describe how to test/QA your changes
rustup toolchain install 1.99.0 --profile minimal -c clippy.cargo +1.99.0 clippy --workspace --all-features -- -D warningsonmainand on this branch.maindouble_must_useerrors indatadog-trace-agentI ran this on macOS arm64 only. The CI run on this PR checks the Linux and Windows jobs.
🤖 Generated with Claude Code