Repository navigation
fix(deps): upgrade simple-git to v4 - #741
Open
mattnewell wants to merge 1 commit into
Open
mattnewell wants to merge 1 commit into
mattnewell wants to merge 1 commit into
Conversation
simple-git 4.0 removed gitP; use the named simpleGit export. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Hi @mattnewell , I submitted a similar PR upgrading simple-git to v4. Feel free to close that one if you're going to merge this one. #739 |
Author
ha! we were ships crossing in the night. technically yours is better, as you added some tests. but i don't have merge rights, either, so 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrades the plugin's direct
simple-gitdependency from^3.36.0to^4.0.2.simple-git 4.0 removed
gitP, the default export andsimple-git/promise.src/git.tscalledsimpleGit.gitP(options), so it now uses the namedsimpleGitexport, which is the documented 4.x form. The options passed (baseDir,binary,maxConcurrentProcesses) are unchanged and still valid in 4.x.Motivation
@simple-git/argv-parser1.1.1 dependency are flagged for CVE-2026-102826, CVE-2026-102827, CVE-2026-102828 and CVE-2026-102829. There is no 3.x release that fixes them; the fixes are in 4.x.Testing Guidelines
sls deployofe2e/fixtures/lambda-nodewithenableSourceCodeIntegration: true: the function'sDD_TAGShad the correctgit.commit.shaandgit.repository_url.Types of changes
Check all that apply
Depends on DataDog/datadog-ci#2540
🤖 Generated with Claude Code