Skip to content

fix(deps): upgrade simple-git to v4 - #741

Open
mattnewell wants to merge 1 commit into
DataDog:mainfrom
mattnewell:simple-git-4
Open

mattnewell wants to merge 1 commit into
DataDog:mainfrom
mattnewell:simple-git-4

Conversation

@mattnewell

@mattnewell mattnewell commented Oct 8, 2026 •

Copy link
Copy Markdown

What does this PR do?

Upgrades the plugin's direct simple-git dependency from ^3.36.0 to ^4.0.2.

simple-git 4.0 removed gitP, the default export and simple-git/promise. src/git.ts called simpleGit.gitP(options), so it now uses the named simpleGit export, which is the documented 4.x form. The options passed (baseDir, binary, maxConcurrentProcesses) are unchanged and still valid in 4.x.

Motivation

Testing Guidelines

  • Build, lint, format check and unit tests pass.
  • sls deploy of e2e/fixtures/lambda-node with enableSourceCodeIntegration: true: the function's DD_TAGS had the correct git.commit.sha and git.repository_url.

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

Depends on DataDog/datadog-ci#2540

🤖 Generated with Claude Code

simple-git 4.0 removed gitP; use the named simpleGit export.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@mattnewell
mattnewell requested a review from a team as a code owner October 8, 2026 14:12
@tusharf5

tusharf5 commented Oct 8, 2026

Copy link
Copy Markdown

Hi @mattnewell , I submitted a similar PR upgrading simple-git to v4. Feel free to close that one if you're going to merge this one. #739

@mattnewell

mattnewell commented Oct 9, 2026 •

Copy link
Copy Markdown
Author

Hi @mattnewell , I submitted a similar PR upgrading simple-git to v4. Feel free to close that one if you're going to merge this one. #739

ha! we were ships crossing in the night. technically yours is better, as you added some tests. but i don't have merge rights, either, so 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants