Repository navigation
Enable the PHP CDN configuration contract - #8035
Draft
leoromanovsky wants to merge 2 commits into
Draft
leoromanovsky wants to merge 2 commits into
leoromanovsky wants to merge 2 commits into
Conversation
Contributor
|
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 2 Pipeline jobs failed
ℹ️ InfoNo other issues found (see more)❄️ No new flaky tests detected Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 9cb324c | Docs | View more details | Give us feedback! |
Environment: Datadog workspace
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PHP's CDN configuration contract is currently disabled, so normal system-test selection cannot verify the new Agentless configuration capability.
Changes and Decisions
Enable the existing configuration-fetching and evaluation contract for PHP-FPM 8.2 at the proposed 1.27.0 boundary. Earlier versions and other PHP weblogs remain gated. The release boundary depends on inclusion of dd-trace-php #4312; keep this draft until that dependency is settled. Exposure and flag-evaluation reporting contracts retain their existing gates.
flowchart LR CDN[Mock configuration CDN] --> Sidecar[libdatadog subprocess] Sidecar -->|Shared memory| PHP[Packaged PHP candidate / FPM 8.2] PHP --> Result[Existing configuration contract]