Repository navigation
refactor: centralize parser validation state - #332
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Validation permits shared date-prototype mutation and misses parent-table conflicts that produce raw TypeErrors.
2 open issues
What changed in this PR
This PR centralizes semantic validation during TOML-to-JavaScript conversion in a path metadata tree, replacing parallel collections and table-scope bookkeeping.
Changes:
- Introduces
PathStateto track definitions and validation rules. - Tracks array-of-tables entries separately for nested and non-contiguous headers.
- Documents the migration plan, compatibility goals, and acceptance criteria.
| File | Description |
|---|---|
src/to-js.ts |
Replaces validation collections with path-based metadata and per-entry scopes. |
docs/PLAN-Parser-Validation-State.md |
Documents the design, migration steps, and validation requirements. |
Review effort: Balanced
Benchmark comparisonThis branch measured against Fixture Benchmark ResultsTime per iteration. Lower is better. Parse, smol-toml spec example (toml-spec-example.toml)
Parse, smol-toml 5MB mixed (5mb-mixed.toml)
Parse, iarna spec example v0.4.0 (0A-spec-01-example-v0.4.0.toml)
Stringify, smol-toml spec example (toml-spec-example.toml)
Stringify, smol-toml 5MB mixed (5mb-mixed.toml)
Stringify, iarna spec example v0.4.0 (0A-spec-01-example-v0.4.0.toml)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Improve parsing approach: