Repository navigation
Release 0.4.1: Sidecar 0.9 discovery and manual AWS deployment - #43
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e97d7b4d01
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| From **0.4.1**, GitHub Actions does not deploy AWS. Pull requests and main pushes | ||
| run checks; a `v*` tag validates and publishes PyPI, GitHub Release and MCP Registry | ||
| metadata. Publishing or retrying a release does not update the running AWS service. |
There was a problem hiding this comment.
After this release removes the AWS job, CONTRIBUTING.md lines 72–103 still tell release operators that a version tag deploys AWS, requires the deployment secrets, and should produce an AWS job, while ROADMAP.md lines 95–101 still describe automatic deployment after PyPI publication. Anyone following those documents can mistake a successful package release for a hosted rollout or wait for a job that no longer exists; update both to describe the new explicit operator deployment flow.
AGENTS.md reference: AGENTS.md:L130-L133
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved documentation inconsistencies and a sibling virtualenv path-precedence issue remain.
3 open issues
What changed in this PR
Release 0.4.1 adds read-only Sidecar 0.9 discovery, pins Sidecar in hosted images, and changes AWS deployment to manual operation.
Changes:
- Adds Sidecar capability discovery and dependency path handling.
- Updates versions, documentation, tests, and image pins.
- Removes automatic AWS deployment from the release workflow.
| File | Reviewed changes |
|---|---|
uv.lock |
Updates locked package version. |
tests/test_sidecar_readiness.py |
Tests Sidecar discovery and path precedence. |
tests/test_hosted_image.py |
Validates image pins and workflow behavior. |
src/deep_agentic_core_mcp/adapters/agentic_sidecar.py |
Adds Sidecar capability detection. |
src/deep_agentic_core_mcp/adapters/__init__.py |
Adjusts sibling environment path handling. |
src/deep_agentic_core_mcp/__init__.py |
Updates package version. |
server.json |
Updates registry metadata versions. |
ROADMAP.md |
Documents Sidecar interoperability. |
README.md |
Updates release and deployment documentation. |
pyproject.toml |
Bumps package version. |
docs/sidecar-0.9.md |
Documents compatibility boundaries. |
deploy/docker/README.md |
Documents manual deployment behavior. |
deploy/docker/Dockerfile.render |
Pins Sidecar 0.9.0. |
deploy/docker/Dockerfile.aws |
Pins Sidecar 0.9.0. |
deploy/aws/CI-CD.md |
Reframes AWS deployment as manual. |
CHANGELOG.md |
Adds 0.4.1 release notes. |
AGENTS.md |
Updates release guidance. |
.github/workflows/release-pypi.yml |
Removes automatic AWS deployment. |
Review effort: Lite
|
Addressed all three findings from the first Copilot review: canonical 0.4.1 version/date fields are synchronized and CONTRIBUTING no longer describes AWS deployment as a tag-release job. Local checks passed; CI is rerunning for the updated head. No second Copilot review requested. |
Discovers installed Sidecar task-authority, revocation and redacted-evidence APIs without issuing grants or connecting to a task. Standalone image recipes pin Sidecar 0.9.0. Native producer evidence stays compatible.
Removes automatic AWS deployment from the tag release pipeline as requested; PyPI, GitHub Release and MCP Registry publishing remain. Existing AWS deployment scripts remain manual operator tools. Also prevents sibling virtualenv dependencies from overriding the active interpreter's locked versions.
Validation: make check (245 passed), discovery/path-precedence regressions, hosted-image pin checks and release-workflow checks. Sidecar 0.9.0 must publish before this image is built.
Please run only one Copilot review. No second review will be requested after fixes.