-
Notifications
You must be signed in to change notification settings - Fork 28
Add mono support for GenTL #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
b346e67
Improve processor discovery and logging
C-Achard 0e7a12f
Add processors package exports
C-Achard df17f15
Move example socket processors to examples module
C-Achard 4c5373e
Skip socket base module in processor scan
C-Achard 70531ac
Update processor_utils.py
C-Achard 1bf0be7
Warn on duplicate processor registration
C-Achard da45dbc
Extract processor registry into new module
C-Achard e55d78d
Normalize recording container handling
C-Achard 8ba7cd4
Add DLC timing instrumentation in GUI path
C-Achard eddba6e
Prioritize latest frame when queue is full
C-Achard b23565a
Lower camera backend logs to debug
C-Achard 0aae19f
Harden DLC worker startup and timing logs
C-Achard 2770045
Disable pose latency debug logging
C-Achard b3d5915
Fix shutdown order in camera preview stop
C-Achard 7d5d39c
Add mono-preserving output mode to GenTL
C-Achard 12b059a
Async recording stop and queued frame dispatch
C-Achard 275aedc
Update recording_manager.py
C-Achard f3d3118
Use runner pose directly in DLC processor
C-Achard 8cdbd7a
Split timing loggers across worker thread
C-Achard 4e4a4a9
pre-commit
C-Achard 35a3541
Remove duplicate node value reader
C-Achard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,12 +25,16 @@ | |
| GUI_MAX_DISPLAY_FPS: float = 30.0 | ||
| ## Recording | ||
| DEFAULT_RECORDING_FPS: float = 30.0 | ||
| ALLOWED_VIDEO_CONTAINERS: set[str] = {"mp4", "avi", "mov"} | ||
| DEFAULT_RECORDING_CONTAINER: str = "mp4" | ||
|
|
||
|
|
||
| ## Debug | ||
| ### Timing logs | ||
| SINGLE_CAMERA_WORKER_DO_LOG_TIMING: bool = False | ||
| MULTI_CAMERA_WORKER_DO_LOG_TIMING: bool = False | ||
| REC_DO_LOG_TIMING: bool = False | ||
| DLC_DO_LOG_TIMING: bool = True | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reminder |
||
| ### Trigger debug logging | ||
| DEBUG_TRIGGER_LOGS = False | ||
| # MAIN_WINDOW_DO_LOG_TIMING: bool = False | ||
|
|
@@ -508,7 +512,7 @@ class RecordingSettings(BaseModel): | |
| enabled: bool = False | ||
| directory: str = Field(default_factory=lambda: str(Path.home() / "Videos" / "deeplabcut-live")) | ||
| filename: str = "session.mp4" | ||
| container: Literal["mp4", "avi", "mov"] = "mp4" | ||
| container: Literal["mp4", "avi", "mov"] = DEFAULT_RECORDING_CONTAINER | ||
| codec: str = "libx264" | ||
| crf: int = Field(default=23, ge=0, le=51) | ||
| fast_encoding: bool = False | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.