Repository navigation
Use camelCase log attribute keys - #4
Merged
Merged
Conversation
The library logs through the consumer's *slog.Logger. Its consumers use camelCase attribute keys and "error" for errors, so snake_case keys and "err" landed in their logs in the wrong style.
Member
Author
|
@matt-defined Feel free to approve, merge, and bump the go.mod in your Nebula PR. |
brad-defined
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library logs through the consumer's
*slog.Logger, and its consumers (nebula and dnclient) use camelCase attribute keys anderrorfor errors. This renames every attribute key the library emits to camelCase anderrtoerrorso its lines match the rest of the consumer's log. Message text, levels, and the set of logged attributes are unchanged.The smoke workflows run on this PR through CI's pull_request trigger.