Repository navigation
Conversation
jasikpark
marked this pull request as ready for review
October 27, 2026 17:56
The paths filter gating PR checks omitted nebula/go.mod, so the Go toolchain bump in #412 skipped Run Go tests. pubspec.yaml and pubspec.lock had the same gap for Flutter dependency bumps, and analysis_options.yaml, swift-format.sh and .swiftformatignore for the lint and format checks they configure. Pushes to main already run every job regardless of paths. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jasikpark
force-pushed
the
ci-filter-manifests
branch
from
October 27, 2026 17:59
83ab6b2 to
b85519c
Compare
jasikpark
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
changesjob's paths filter gates the Go, Flutter and Swift checks on PRs, but it doesn't list the files those checks are configured by. So #412 (Go 1.26.10) skippedRun Go testseven though it changed the toolchain the tests build with.The filter had
nebula/go.sumbut notnebula/go.mod. That covers dependency bumps, which change both files. A toolchain bump changes only thegodirective ingo.mod: that directive isn't a module dependency, so it has nogo.sumentry.setup-goreads the version fromgo.mod(go-version-file), so ago.mod-only change can switch the compiler and standard library without triggering any Go checks.The same gap, added here:
pubspec.yaml,pubspec.lock: Flutter dependency bumpsanalysis_options.yaml: the rulesRun flutter lintenforcesswift-format.sh,.swiftformatignore: whatRun swift formatruns and skipsPushes to
mainalready run every job regardless of paths, so this only affects PR checks.🤖 Generated with Claude Code