Repository navigation
Conversation
Deploying docs-nebula with
|
| Latest commit: |
1a15505
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d2a43285.docs-nebula.pages.dev |
| Branch Preview URL: | https://tun-offloads.docs-nebula.pages.dev |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
JackDoan
marked this pull request as ready for review
September 14, 2026 16:50
jasikpark
reviewed
Sep 14, 2026
jasikpark
left a comment
Collaborator
There was a problem hiding this comment.
Checked this against slackhq/nebula@abff1a4. Accurate throughout, including the batch memory math and the platform caveats. One thing worth adding:
listen.batch: 1 silently disables GRO. udp_linux.go:80 is the only prepareGRO call site and reads if s.Batch > 1 && s.Offloads, with nothing logged when it's skipped. Since the new listen.batch paragraph invites lowering the value to save memory, worth noting that 1 turns receive-side offload off entirely. The gate is GRO-only, GSO still applies at batch: 1.
Two optional wording nits on listen.udp_offloads, both about "probed when the socket is created, and Nebula falls back to standard sends and receives":
- The send-side fallback is still
sendmmsgwith one entry per datagram, so "unbatched sends" is more precise than "standard sends". - Fallback isn't only at creation. An
EIOon a superpacket disables GSO at runtime and replays the batch, since the setsockopt probe can't see per-route limitations.
Contributor
Author
|
Superseded by #390 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maybe don't merge until 1.12 is cut