Conversation
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if available)
Depends on quickjs-ng/quickjs#1745.
Description of changes
Expose
JS_DiscardPendingJobsin the platform bindings so hosts can release queued jobs without executing callbacks or destroying the runtime.Tests cover empty and repeated discard, callback suppression, argument finalization, and runtime reuse. They also verify that jobs enqueued by native finalizers remain pending and that the returned count covers only the original queue.
This remains a draft until the engine API merges and the QuickJS submodule advances. The committed submodule is unchanged.
Validation on the latest upstream baseline, with the dependent engine patch applied locally: all 231 tests and doc tests in
cargo test --all --no-default-features --features full-asyncpassed on macOS, along withcargo fmt --all -- --checkandcargo clippy --all --all-targets --features full-async,bindgen -- -D warnings.Checklist