Repository navigation
feat(client): add --contract and --rpc flags with env var fallbacks (closes #183) - #186
Closed
dezzy-music wants to merge 1 commit into
Closed
dezzy-music wants to merge 1 commit into
dezzy-music wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces hard-coded
CONTRACT_IDandRPC_URLconstants inclient/src/index.tswith--contractand--rpccommand-line flags, supported byDEPRADAR_CONTRACT_IDandDEPRADAR_RPC_URLenvironment variables as fallbacks, and defaulting to the live testnet deployment values.Closes #183
Tasks Completed
--contractand--rpcflags inclient/src/index.ts.DEPRADAR_CONTRACT_IDandDEPRADAR_RPC_URLenvironment variable fallbacks with default constants.client/README.mddocumenting usage options, flags, and environment variables.PROGRESS.md.Acceptance Criteria
npm run typecheckpasses inclient/PROGRESS.mdentry added, and the PR description includesCloses #183Verification
npm run typecheckpasses with zero errors.npm start -- --bounty-id 1successfully queries live contract state.npm start -- --bounty-id 1 --contract <id> --rpc <url>correctly passes and executes custom endpoint overrides.Stellar Address (Stellar Wave Program)
GDLCJGQLXZGDAAT5QGRF6FM2MBEER3FPYGCSVPXYL47G2ABIOX2M2S6K