Skip to content

devex: pin Rust toolchain 1.94.1 with rustfmt, clippy, and wasm target (closes #159) #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dezzy-music wants to merge 1 commit into from
Closed

devex: pin Rust toolchain 1.94.1 with rustfmt, clippy, and wasm target (closes #159) #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,17 @@ open a PR that references it.
Prerequisites: a stable Rust toolchain, the `wasm32v1-none` target (for the
contract), and Node.js 22+ (for `client/`).

```bash
rustup target add wasm32v1-none
The Rust toolchain, its components (`rustfmt`, `clippy`), and the `wasm32v1-none`
target are pinned in [`rust-toolchain.toml`](rust-toolchain.toml). When using
`rustup`, invoking any `cargo` command inside the repo automatically installs
and selects the pinned version.

### Bumping the Rust Toolchain
To bump the Rust version:
1. Update `channel = "..."` in `rust-toolchain.toml` to the new target version.
2. Run `cargo fmt --all -- --check` and `cargo clippy --workspace --all-targets --locked -- -D warnings` to verify new lints.
3. Verify tests and the wasm build: `cargo test --workspace --locked` and `cargo build -p deprader-router --target wasm32v1-none --release --locked`.
4. Update `PROGRESS.md` and submit a PR with the bump.

# Off-chain toolkit + contract unit tests
cargo test --workspace --locked
Expand Down
8 changes: 8 additions & 0 deletions PROGRESS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,3 +319,11 @@ is closed — see [CONTRIBUTING.md](CONTRIBUTING.md).
- **By:** ALLEN-AYODEJI
- **Closes:** N/A
- **Status:** Merged.

### Devex — Pin the Rust toolchain

- **What:** Adds `rust-toolchain.toml` pinning the Rust compiler channel to `1.94.1` with `rustfmt`, `clippy` components and the `wasm32v1-none` Soroban contract compilation target. Updates `CONTRIBUTING.md` with instructions on how contributors and maintainers can bump the pinned toolchain.
- **Verified:** `cargo fmt --all -- --check`, `cargo clippy --workspace --all-targets --locked -- -D warnings`, `cargo test --workspace --locked`, and `cargo build -p deprader-router --target wasm32v1-none --release --locked` all pass under the pinned toolchain.
- **By:** dezzy-music
- **Closes:** #159
- **Status:** PR open.
5 changes: 5 additions & 0 deletions rust-toolchain.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[toolchain]
channel = "1.94.1"
components = ["rustfmt", "clippy"]
targets = ["wasm32v1-none"]
profile = "minimal"