Repository navigation
feat(scanner): agree on a standard issue_ref format for findings - #198
Closed
dezzy-music wants to merge 1 commit into
Closed
dezzy-music wants to merge 1 commit into
dezzy-music wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Proposes and formalizes a standardized finding reference grammar across DepRadar off-chain crawlers, on-chain contracts, and the dashboard:
<ecosystem>:<package>[@<version>]#<kind>[:<advisory>]Provides complete parsing and formatting utilities with round-trip unit tests in both Rust (
deprader::model) and TypeScript (frontend/src/lib/format.ts), accompanied by comprehensive documentation indocs/issue-ref.md.Closes #162
Tasks Completed
docs/issue-ref.md.FindingRef,format_issue_ref, andparse_issue_refinsrc/model.rs(exposed viasrc/lib.rs).FindingRefinterface,formatIssueRef, andparseIssueRefinfrontend/src/lib/format.ts.src/model.rs, 30 tests in crate).frontend/src/lib/format.test.ts, 25 tests in dashboard).PROGRESS.md.Acceptance Criteria
cargo fmt,cargo clippy -- -D warningsandcargo test --workspacepassnpm run lint,typecheck,testandbuildpass infrontend/PROGRESS.mdentry added, and the PR description includesCloses #162Stellar Address (Stellar Wave Program)
GDLCJGQLXZGDAAT5QGRF6FM2MBEER3FPYGCSVPXYL47G2ABIOX2M2S6K