fix(build): support Visual Studio 2026 on Windows - #369
Merged
Merged
Conversation
The windows-2025 runner now ships Visual Studio 2026, which node-gyp 10.0.1 cannot detect. Require node-gyp 12.1 or newer and resolve 12.4.0 in the lockfile, preserving the Windows runner and all existing tests. Co-authored-by: Omp <noreply@omp.sh> Co-authored-by: GPT-6 Astra <noreply@openai.com>
dmfay
approved these changes
Sep 9, 2026
dmfay
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Require
node-gyp^12.1.0and update the lockfile to resolve12.4.0, which supports Visual Studio 2026. Keep thewindows-2025runner and all existing tests enabled.Why
The Windows runner image now ships Visual Studio 2026 (18.x), but the locked
node-gyp@10.0.1rejects it as an unknown version. This causesnpm installto fail while building thetree-sitterdependency, before the Node binding tests run. Updating the build dependency fixes compiler discovery rather than downgrading the runner or skipping coverage.The lockfile removes obsolete transitive dependencies from the old
node-gypdependency graph; unrelated dependency versions are unchanged.References