Conversation
- Implement FastMCP server package (mcp_server/) with news_search, get_article, list_categories, get_article_count tools - Add ToolCallingProvider interface and AgentOrchestrator multi-turn tool execution loop - Implement dual-mode ChatbotService (autonomous global search vs. article reader context) - Add Dockerfile.mcp, update docker-compose.yml and dev.sh with mcp-server on port 8002 (SSE) - Remove outdated Julep SDK provider and Julep RAG backend - Update logger badge styling (removed square brackets) - Add structured extraction schemas (pipeline/extraction_schemas.py) Closes #29
There was a problem hiding this comment.
Pull request overview
This PR moves DistillNews toward MCP-compatible, tool-calling agent flows by introducing a dedicated MCP server package/service, adding a tool-calling provider interface + orchestrator loop, and removing the legacy Julep agent/RAG backends.
Changes:
- Add an MCP server (
mcp_server/) withnews_search/get_articletools plus Docker/compose wiring for deployment. - Introduce tool/function calling primitives (
ToolDefinition,ToolCall,AgentMessage), aToolCallingProviderinterface, and anAgentOrchestratorloop; update chatbot + OpenAI provider accordingly. - Remove Julep agent and RAG backend support; update tests and env/config/docs/examples to match.
Reviewed changes
Copilot reviewed 28 out of 30 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/logger.py | Adjusts badge formatting output (affects log output matching). |
| service/logger.py | Same badge-format change for service logger. |
| tests/test_server_routes.py | Updates assertions to match new badge formatting. |
| tests/test_logger.py | Updates logger badge formatting assertions. |
| tests/test_chatbot_and_embeddings.py | Updates chatbot test to match tool-calling agent interface usage. |
| tests/test_agents_and_factory.py | Expands tests for new tool-calling primitives (but currently misses orchestrator coverage). |
| service/rag/factory.py | Removes julep RAG backend option and updates error message. |
| service/rag/backends/julep.py | Removes Julep doc-store backend implementation. |
| service/chatbot/wiring.py | Updates chatbot wiring to new ChatbotService initialization. |
| service/chatbot/service.py | Replaces template-based prompting with an orchestrated tool-calling flow + system prompts. |
| service/agents/providers/openai.py | Extends OpenAI provider to support tool calling via OpenAI tools API. |
| service/agents/providers/julep.py | Removes Julep provider implementation. |
| service/agents/orchestrator.py | Adds multi-turn orchestrator for executing tool calls. |
| service/agents/factory.py | Removes Julep provider option; keeps OpenAI. |
| service/agents/base.py | Adds tool-calling dataclasses and ToolCallingProvider interface. |
| service/agents/init.py | Re-exports new tool-calling types. |
| pipeline/extraction_schemas.py | Adds JSON-schema tool definitions for structured extraction/classification/formatting. |
| mcp_server/tools/search.py | Implements MCP-side news_search using in-memory vector store + remote embeddings. |
| mcp_server/tools/articles.py | Implements MCP-side article fetch/count utilities. |
| mcp_server/tools/init.py | Adds MCP tools package marker. |
| mcp_server/requirements.txt | Adds MCP server dependency set. |
| mcp_server/app.py | Defines FastMCP tools and server entrypoint. |
| mcp_server/main.py | Enables python -m mcp_server execution. |
| mcp_server/init.py | Package marker for MCP server module. |
| Dockerfile.mcp | Adds container build for MCP server. |
| docker-compose.yml | Adds mcp-server service and environment wiring. |
| dev.sh | Installs MCP deps and starts MCP server in local dev (plus a new typo in output). |
| config.py | Removes Julep-related config properties. |
| .env.example | Removes Julep options from example environment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires adding Dockerfile.mcp to deployment. Resolves #29