Fix UR tutorial solver limit warnings - #572
Merged
Merged
Conversation
Configure atomic-action UR tutorial solvers with DexSim's runtime +/-2*pi limits and preserve them for dual-arm PyTorch solvers. Add regression coverage for the no-op limit-sync warning.
Greptile SummaryThis PR aligns UR5 and UR10 tutorial solver limits with DexSim’s canonical ±2π runtime range and preserves those limits when dual-arm tutorials replace the UR solver with the PyTorch solver.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness, security, or compatibility issues identified. The configured
|
| Filename | Overview |
|---|---|
| scripts/tutorials/atomic_action/tutorial_utils.py | Defines the canonical six-joint ±2π limits and applies them consistently to both UR tutorial solver configurations. |
| scripts/tutorials/atomic_action/scenario_utils.py | Preserves the base solver’s joint limits when constructing dual-arm PyTorch solver configurations. |
| tests/sim/atomic_actions/test_tutorial_utils.py | Adds focused regression tests for UR limit configuration, warning suppression, and dual-arm solver propagation. |
Reviews (1): Last reviewed commit: "fix(tutorials): align UR solver joint li..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aligns the UR5 and UR10 atomic-action tutorial solver limits with DexSim's runtime ±2π joint range. It also preserves those limits for dual-arm tutorial paths that use the PyTorch solver.
The source URDF encodes ±6.2832 while DexSim reports ±2π, which previously produced a no-op hard-limit clamp warning during robot construction.
Dependencies: None.
Issue: none provided.
Type of change
Screenshots
Not applicable; this is a configuration and regression-test change.
Checklist
black .command to format the code base.python docs/scripts/check_api_docs.py), if applicableValidation
black --check --diff --color ./python docs/scripts/check_api_docs.pypytest -q tests/sim/atomic_actions/test_tutorial_utils.py(68 passed)