Add EmbodiChain pull request review skill - #574
Conversation
Greptile SummaryAdds a canonical read-only pull-request review skill and exposes it through Claude, OpenAI, Copilot, and project-level routing.
Confidence Score: 4/5The local-working-tree review path should be fixed before merging because it can silently omit the contents of newly created untracked files. The adapters and review matrix are coherently connected, but the canonical workflow promises complete working-tree coverage while only listing untracked paths, allowing defects in those files to escape review. Files Needing Attention: .agents/skills/review-pr/SKILL.md
|
| Filename | Overview |
|---|---|
| .agents/skills/review-pr/SKILL.md | Introduces the canonical review workflow, but its local target-resolution commands do not load untracked file contents. |
| .agents/skills/review-pr/references/review-matrix.md | Adds focused review checks and evidence surfaces for the repository's major subsystems. |
| .claude/skills/review-pr/SKILL.md | Adds a thin Claude adapter that delegates to the canonical skill. |
| .github/copilot/review-pr.md | Adds a thin Copilot adapter that delegates to the canonical skill. |
| AGENTS.md | Registers the new review skill and distinguishes it from readiness checks and PR creation. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
User[Review request] --> Router[Project or tool routing]
Router --> Claude[Claude adapter]
Router --> Copilot[Copilot adapter]
Router --> OpenAI[OpenAI metadata]
Claude --> Canonical[Canonical review-pr skill]
Copilot --> Canonical
OpenAI --> Canonical
Canonical --> Matrix[Subsystem review matrix]
Canonical --> Review[Evidence-backed review output]
Prompt To Fix All With AI
### Issue 1
.agents/skills/review-pr/SKILL.md:38
**Untracked file contents are skipped**
When `/review-pr` examines a working tree containing a newly created untracked source or configuration file, `git ls-files --others --exclude-standard` returns only its path and no later step requires reading its contents, causing defects confined to that file to be omitted from the review.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "feat(agent): add pull request review ski..." | Re-trigger Greptile
|
|
||
| For a local working tree, inspect all tracked, staged, and untracked changes: | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
Untracked file contents are skipped
When /review-pr examines a working tree containing a newly created untracked source or configuration file, git ls-files --others --exclude-standard returns only its path and no later step requires reading its contents, causing defects confined to that file to be omitted from the review.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .agents/skills/review-pr/SKILL.md
Line: 38
Comment:
**Untracked file contents are skipped**
When `/review-pr` examines a working tree containing a newly created untracked source or configuration file, `git ls-files --others --exclude-standard` returns only its path and no later step requires reading its contents, causing defects confined to that file to be omitted from the review.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Description
This PR adds a canonical
review-prskill for read-only, evidence-backed review of EmbodiChain pull requests, branches, commits, patches, and working-tree diffs.The skill defines target resolution, architecture-aware review passes, candidate-proof requirements, priority rules, clickable evidence links, a findings summary table, and a separate review-status table. It also adds a subsystem review matrix, thin Claude and GitHub Copilot adapters, and project instruction/index entries.
Dependencies: None.
Issue: N/A.
Type of change
Screenshots
N/A.
Validation
black --check --diff --color ./— passed; 827 files unchangedpython docs/scripts/check_api_docs.pyfrom a clean source tree — passed; 1669/1669 exports documentedpython /home/dex/.codex/skills/.system/skill-creator/scripts/quick_validate.py .agents/skills/review-pr— passedgit diff --check— passedChecklist