Skip to content

curate knowledge skill - #3

Open
asadiq-dius wants to merge 17 commits into
mainfrom
feature/curate-knowledge-skill
Open

curate knowledge skill#3
asadiq-dius wants to merge 17 commits into
mainfrom
feature/curate-knowledge-skill

Conversation

@asadiq-dius

Copy link
Copy Markdown

No description provided.

@bsigney bsigney left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good skill Aamer. Two things I would prioritise to fix before anything else

Add the untrusted-input boundary to SKILL.md, and wire the four scripts into step 10 after making check-frontmatter.sh fail closed. Those two turn roughly half the findings above from live risks into ordinary bugs.
After that, the completeness.md source-deletion path is the one I'd want gone entirely or tightened.

Comment thread commands/knowledge-curation.md Outdated
Comment thread skills/knowledge-curation/README.md Outdated
Comment thread skills/knowledge-curation/README.md Outdated
Comment thread skills/knowledge-curation/SKILL.md
Comment thread skills/knowledge-curation/SKILL.md Outdated
Comment thread skills/knowledge-curation/scripts/check-frontmatter.sh Outdated
Comment thread skills/knowledge-curation/scripts/check-frontmatter.sh Outdated
Comment thread skills/knowledge-curation/scripts/check-placement.sh Outdated
Comment thread skills/knowledge-curation/scripts/check-placement.sh Outdated
Comment thread skills/knowledge-curation/scripts/check-structure.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants