Skip to content

refactor: combine Plan and PlanModel #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shree-iyengar-dls wants to merge 1 commit into from
Closed

refactor: combine Plan and PlanModel #1741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions src/blueapi/core/bluesky_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
)
from bluesky.utils import Msg, MsgGenerator
from ophyd_async.core import Device as AsyncDevice
from pydantic import BaseModel, Field

from blueapi.utils import BlueapiBaseModel

Expand Down Expand Up @@ -81,20 +80,6 @@ def is_bluesky_plan_generator(func: PlanGenerator) -> bool:
return False


class Plan(BlueapiBaseModel):
"""
A plan that can be run
"""

name: str = Field(description="Referenceable name of the plan")
description: str | None = Field(
description="Description/docstring of the plan", default=None
)
model: type[BaseModel] = Field(
description="Validation model of the parameters for the plan"
)


class DataEvent(BlueapiBaseModel):
"""
Event representing collection of some data. Conforms to the Bluesky event model:
Expand Down
Loading