Skip to content

refactor: Combining Plan and Plan functions - #1743

Open
shree-iyengar-dls wants to merge 3 commits into
mainfrom
combing_plans_and_planfunctions
Open

shree-iyengar-dls wants to merge 3 commits into
mainfrom
combing_plans_and_planfunctions

Conversation

@shree-iyengar-dls

Copy link
Copy Markdown
Contributor

Fixes #180

Summary of changes:

  • class Plan in blueapi/core/bluesky_types.py is no longer a BlueapiBaseModel but is now a dataclass
  • class Plan contains plan_function which is of the type PlanGenerator
  • class PlanModel remains unchanged
  • the changes above mean we no longer have the duplicated plan_functions dictionary in class BlueskyContext

@codecov

codecov Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.46%. Comparing base (4353ae2) to head (34ce285).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1743   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files          49       49           
  Lines        3791     3791           
=======================================
  Hits         3657     3657           
  Misses        134      134           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shree-iyengar-dls shree-iyengar-dls changed the title Combining Plan and Plan functions refactor: Combining Plan and Plan functions Nov 5, 2026
@shree-iyengar-dls
shree-iyengar-dls marked this pull request as ready for review November 5, 2026 17:57
@shree-iyengar-dls
shree-iyengar-dls requested a review from a team as a code owner November 5, 2026 17:57

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combine context.plans and context.plan_functions into a single dictionary

1 participant