Repository navigation
refactor: Wrap Devices in BlueapiDevice - #1744
Open
shree-iyengar-dls wants to merge 4 commits into
Open
shree-iyengar-dls wants to merge 4 commits into
shree-iyengar-dls wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1744 +/- ##
==========================================
- Coverage 96.46% 96.42% -0.05%
==========================================
Files 49 49
Lines 3791 3801 +10
==========================================
+ Hits 3657 3665 +8
- Misses 134 136 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until #1739 gets merged, this PR wraps the devices in
BlueskyContextin aBlueapiDevicedataclass. After #1739, there will be a follow up andBlueapiDevicewill hold the device and the tree.Summary of changes:
BlueskyContext.deviceswasdict[str, Device]where Device represented bluesky protocols. NowBlueskyContext.devicesis adict[str, BlueapiDevice]DeviceModelremains unchangedctx.devicesnow holdsBlueapiDevices (wrappers) instead of actual devices so when we want to access the actual device, we get it fromentry.devicefind_deviceunwraps theBlueapiDeviceand returns aDevicegeneric_boundsandis_compatible_argsfunctions accept normal unwrappedDevicesand wrappedBlueapiDevices(had to do this to fix linting issues but not sure if its correct)